Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4703)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 9965017: views: Rename ComboboxListener::ItemChanged to something more accurate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: combo_box -> combobox Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index 85c2846e665a73bf81bf6738bd84ab7d3f2fe995..bb29a424074a7184a2b101351fd4617e2cb7151c 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -286,12 +286,9 @@ void BookmarkBubbleView::LinkClicked(views::Link* source, int event_flags) {
StartFade(false);
}
-void BookmarkBubbleView::ItemChanged(views::Combobox* combo_box,
- int prev_index,
- int new_index) {
- if (new_index + 1 == parent_model_.GetItemCount()) {
- content::RecordAction(
- UserMetricsAction("BookmarkBubble_EditFromCombobox"));
+void BookmarkBubbleView::OnSelectedIndexChanged(views::Combobox* combobox) {
+ if (combobox->selected_index() + 1 == parent_model_.GetItemCount()) {
+ content::RecordAction(UserMetricsAction("BookmarkBubble_EditFromCombobox"));
ShowEditor();
}
}
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h ('k') | chrome/browser/ui/views/cookie_info_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698