Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: chrome/browser/chromeos/options/vpn_config_view.cc

Issue 9965017: views: Rename ComboboxListener::ItemChanged to something more accurate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: combo_box -> combobox Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/options/vpn_config_view.cc
diff --git a/chrome/browser/chromeos/options/vpn_config_view.cc b/chrome/browser/chromeos/options/vpn_config_view.cc
index e8fe484aafa6ee14336c3543a7b91948abffb8d2..80317f63c912c763c0d022f816836c1b4f37fb7f 100644
--- a/chrome/browser/chromeos/options/vpn_config_view.cc
+++ b/chrome/browser/chromeos/options/vpn_config_view.cc
@@ -226,15 +226,12 @@ void VPNConfigView::ButtonPressed(views::Button* sender,
const views::Event& event) {
}
-void VPNConfigView::ItemChanged(views::Combobox* combo_box,
- int prev_index, int new_index) {
- if (prev_index == new_index)
- return;
- if (combo_box == provider_type_combobox_) {
- provider_type_ = static_cast<ProviderType>(new_index);
+void VPNConfigView::OnSelectedIndexChanged(views::Combobox* combobox) {
+ if (combobox == provider_type_combobox_) {
+ provider_type_ = static_cast<ProviderType>(combobox->selected_index());
UpdateControls();
- } else if (combo_box == user_cert_combobox_ ||
- combo_box == server_ca_cert_combobox_) {
+ } else if (combobox == user_cert_combobox_ ||
+ combobox == server_ca_cert_combobox_) {
// Do nothing.
} else {
NOTREACHED();
« no previous file with comments | « chrome/browser/chromeos/options/vpn_config_view.h ('k') | chrome/browser/chromeos/options/wifi_config_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698