Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: webkit/dom_storage/dom_storage_namespace.cc

Issue 9963107: Persist sessionStorage on disk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review (pkasting) Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/dom_storage/dom_storage_namespace.h ('k') | webkit/dom_storage/session_storage_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/dom_storage/dom_storage_namespace.cc
diff --git a/webkit/dom_storage/dom_storage_namespace.cc b/webkit/dom_storage/dom_storage_namespace.cc
index 350444c9b52bd1c5eb0e70ee95ccb6db55162b52..693954c97467617529d98bfadda8e1c9fad92b95 100644
--- a/webkit/dom_storage/dom_storage_namespace.cc
+++ b/webkit/dom_storage/dom_storage_namespace.cc
@@ -5,10 +5,13 @@
#include "webkit/dom_storage/dom_storage_namespace.h"
#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/location.h"
#include "base/logging.h"
#include "webkit/dom_storage/dom_storage_area.h"
#include "webkit/dom_storage/dom_storage_task_runner.h"
#include "webkit/dom_storage/dom_storage_types.h"
+#include "webkit/dom_storage/session_storage_database.h"
namespace dom_storage {
@@ -23,10 +26,12 @@ DomStorageNamespace::DomStorageNamespace(
DomStorageNamespace::DomStorageNamespace(
int64 namespace_id,
const std::string& persistent_namespace_id,
+ SessionStorageDatabase* session_storage_database,
DomStorageTaskRunner* task_runner)
: namespace_id_(namespace_id),
persistent_namespace_id_(persistent_namespace_id),
- task_runner_(task_runner) {
+ task_runner_(task_runner),
+ session_storage_database_(session_storage_database) {
DCHECK_NE(kLocalStorageNamespaceId, namespace_id);
}
@@ -43,7 +48,7 @@ DomStorageArea* DomStorageNamespace::OpenStorageArea(const GURL& origin) {
area = new DomStorageArea(origin, directory_, task_runner_);
} else {
area = new DomStorageArea(namespace_id_, persistent_namespace_id_, origin,
- task_runner_);
+ session_storage_database_, task_runner_);
}
areas_[origin] = AreaHolder(area, 1);
return area;
@@ -64,17 +69,29 @@ DomStorageNamespace* DomStorageNamespace::Clone(
DCHECK_NE(kLocalStorageNamespaceId, namespace_id_);
DCHECK_NE(kLocalStorageNamespaceId, clone_namespace_id);
DomStorageNamespace* clone = new DomStorageNamespace(
- clone_namespace_id, clone_persistent_namespace_id, task_runner_);
+ clone_namespace_id, clone_persistent_namespace_id,
+ session_storage_database_, task_runner_);
AreaMap::const_iterator it = areas_.begin();
+ // Clone the in-memory structures.
for (; it != areas_.end(); ++it) {
DomStorageArea* area = it->second.area_->ShallowCopy(
clone_namespace_id, clone_persistent_namespace_id);
clone->areas_[it->first] = AreaHolder(area, 0);
}
+ // And clone the on-disk structures, too.
+ if (session_storage_database_.get()) {
+ task_runner_->PostShutdownBlockingTask(
+ FROM_HERE,
+ DomStorageTaskRunner::COMMIT_SEQUENCE,
+ base::Bind(base::IgnoreResult(&SessionStorageDatabase::CloneNamespace),
+ session_storage_database_.get(), persistent_namespace_id_,
+ clone_persistent_namespace_id));
+ }
return clone;
}
void DomStorageNamespace::DeleteOrigin(const GURL& origin) {
+ DCHECK(!session_storage_database_.get());
AreaHolder* holder = GetAreaHolder(origin);
if (holder) {
holder->area_->DeleteOrigin();
« no previous file with comments | « webkit/dom_storage/dom_storage_namespace.h ('k') | webkit/dom_storage/session_storage_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698