Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 9963104: Regression test for large string joins. (Closed)

Created:
8 years, 8 months ago by m.m.capewell
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Regression test for large string joins. BUG=none TEST=cctest/test-strings/AsciiArrayJoin Committed: https://code.google.com/p/v8/source/detail?r=11229

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M test/cctest/test-strings.cc View 1 2 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
m.m.capewell
Test for http://code.google.com/p/v8/source/detail?r=11212
8 years, 8 months ago (2012-04-03 14:29:16 UTC) #1
Michael Starzinger
Drive-by comments: This CL is missing changes in cctest.gyp to make the unit test work ...
8 years, 8 months ago (2012-04-03 15:43:06 UTC) #2
m.m.capewell
8 years, 8 months ago (2012-04-03 16:59:51 UTC) #3
danno
Seems like this belongs in test/cctest/test-strings.cc rather than test-compiler.cc
8 years, 8 months ago (2012-04-04 09:41:01 UTC) #4
m.m.capewell
Moved test to test-strings.
8 years, 8 months ago (2012-04-04 10:48:51 UTC) #5
Michael Starzinger
8 years, 8 months ago (2012-04-04 14:37:39 UTC) #6
LGTM. Minor cosmetic change. Landed.

Powered by Google App Engine
This is Rietveld 408576698