Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/regexp-macro-assembler-mips.cc

Issue 9963051: Cosmetic (ARM/MIPS): Use FieldMemOperand where appropriate. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 Handle<ByteArray> table, 506 Handle<ByteArray> table,
507 Label* on_bit_set) { 507 Label* on_bit_set) {
508 __ li(a0, Operand(table)); 508 __ li(a0, Operand(table));
509 if (mode_ != ASCII || kTableMask != String::kMaxAsciiCharCode) { 509 if (mode_ != ASCII || kTableMask != String::kMaxAsciiCharCode) {
510 __ And(a1, current_character(), Operand(kTableSize - 1)); 510 __ And(a1, current_character(), Operand(kTableSize - 1));
511 __ Addu(a0, a0, a1); 511 __ Addu(a0, a0, a1);
512 } else { 512 } else {
513 __ Addu(a0, a0, current_character()); 513 __ Addu(a0, a0, current_character());
514 } 514 }
515 515
516 __ lbu(a0, MemOperand(a0, ByteArray::kHeaderSize - kHeapObjectTag)); 516 __ lbu(a0, FieldMemOperand(a0, ByteArray::kHeaderSize));
517 BranchOrBacktrack(on_bit_set, ne, a0, Operand(zero_reg)); 517 BranchOrBacktrack(on_bit_set, ne, a0, Operand(zero_reg));
518 } 518 }
519 519
520 520
521 bool RegExpMacroAssemblerMIPS::CheckSpecialCharacterClass(uc16 type, 521 bool RegExpMacroAssemblerMIPS::CheckSpecialCharacterClass(uc16 type,
522 Label* on_no_match) { 522 Label* on_no_match) {
523 // Range checks (c in min..max) are generally implemented by an unsigned 523 // Range checks (c in min..max) are generally implemented by an unsigned
524 // (c - min) <= (max - min) check. 524 // (c - min) <= (max - min) check.
525 switch (type) { 525 switch (type) {
526 case 's': 526 case 's':
(...skipping 779 matching lines...) Expand 10 before | Expand all | Expand 10 after
1306 } 1306 }
1307 1307
1308 1308
1309 #undef __ 1309 #undef __
1310 1310
1311 #endif // V8_INTERPRETED_REGEXP 1311 #endif // V8_INTERPRETED_REGEXP
1312 1312
1313 }} // namespace v8::internal 1313 }} // namespace v8::internal
1314 1314
1315 #endif // V8_TARGET_ARCH_MIPS 1315 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698