Fix some warnings.

frog/lib/corelib_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("dart:coreimpl");
 
 #source("../../corelib/src/implementation/dual_pivot_quicksort.dart");
 #source("../../corelib/src/implementation/duration_implementation.dart");
 #source("../../corelib/src/implementation/exceptions.dart");
 #source("../../corelib/src/implementation/collections.dart");
@@ skipping 48 matching lines @@
   void sort(int compare(E a, E b)) native;
   void copyFrom(List<Object> src, int srcStart, int dstStart, int count) native;
   int indexOf(E element, [int start]) native;
   int lastIndexOf(E element, [int start]) native;
   void clear() { length = 0; }
 
   E removeLast() native "return this.pop();";
 
   E last() => this[this.length-1];
 
-  List<E> getRange(int start, int length) native """
-    if (length == 0) return [];
-    if (length < 0) throw new IllegalArgumentException('length');
-    if (start < 0 || start + length > this.length)
+  List<E> getRange(int start, int rangeLength) native """
+    if (rangeLength == 0) return [];
+    if (rangeLength < 0) throw new IllegalArgumentException('length');
+    if (start < 0 || start + rangeLength > this.length)
       throw new IndexOutOfRangeException(start);
-    return this.slice(start, start + length);
+    return this.slice(start, start + rangeLength);
   """ { throw new IllegalArgumentException('');
         throw new IndexOutOfRangeException(0); }
 
-  void setRange(int start, int length, List<E> from, [int startFrom = 0]) {
+  void setRange(int start, int rangeLength, List<E> from, [int startFrom = 0]) {
     // length of 0 prevails and should not throw exceptions.
-    if (length == 0) return;
-    if (length < 0) throw new IllegalArgumentException('length is negative');
+    if (rangeLength == 0) return;
+    if (rangeLength < 0) {
+      throw new IllegalArgumentException('length is negative');
+    }
 
     if (start < 0) throw new IndexOutOfRangeException(start);
 
-    int end = start + length;
+    int end = start + rangeLength;
     if (end > this.length) throw new IndexOutOfRangeException(end);
 
     if (startFrom < 0) throw new IndexOutOfRangeException(startFrom);
 
-    int endFrom = startFrom + length;
+    int endFrom = startFrom + rangeLength;
     if (endFrom > from.length) throw new IndexOutOfRangeException(endFrom);
 
-    for (var i = 0; i < length; ++i)
+    for (var i = 0; i < rangeLength; ++i)
       this[start + i] = from[startFrom + i];
   }
 
-  void removeRange(int start, int length) native """
-    if (length == 0) return;
-    if (length < 0) throw new IllegalArgumentException('length');
-    if (start < 0 || start + length > this.length)
+  void removeRange(int start, int rangeLength) native """
+    if (rangeLength == 0) return;
+    if (rangeLength < 0) throw new IllegalArgumentException('length');
+    if (start < 0 || start + rangeLength > this.length)
       throw new IndexOutOfRangeException(start);
-    this.splice(start, length);
+    this.splice(start, rangeLength);
   """ { throw new IllegalArgumentException('');
         throw new IndexOutOfRangeException(0); }
 
-  void insertRange(int start, int length, [E initialValue]) native """
-    if (length == 0) return;
-    if (length < 0) throw new IllegalArgumentException('length');
+  void insertRange(int start, int rangeLength, [E initialValue]) native """
+    if (rangeLength == 0) return;
+    if (rangeLength < 0) throw new IllegalArgumentException('length');
     if (start < 0 || start > this.length)
       throw new IndexOutOfRangeException(start);
 
     // Splice in the values with a minimum of array allocations.
-    var args = new Array(length + 2);
+    var args = new Array(rangeLength + 2);
     args[0] = start;
     args[1] = 0;
-    for (var i = 0; i < length; i++) {
+    for (var i = 0; i < rangeLength; i++) {
       args[i + 2] = initialValue;
     }
     this.splice.apply(this, args);
     """ { throw new IllegalArgumentException('');
           throw new IndexOutOfRangeException(0); }
 
   // Collection<E> members:
   void forEach(void f(E element)) native;
   Collection<E> filter(bool f(E element)) native;
   Collection map(f(E element)) native;
@@ skipping 224 matching lines @@
       List<String> this._groups);
 
   final String pattern;
   final String str;
   final int _start;
   final int _end;
   final List<String> _groups;
 
   int start() => _start;
   int end() => _end;
-  String group(int group) => _groups[group];
-  String operator [](int group) => _groups[group];
+  String group(int groupIndex) => _groups[groupIndex];
+  String operator [](int groupIndex) => _groups[groupIndex];
   int groupCount() => _groups.length;
 
-  List<String> groups(List<int> groups) {
+  List<String> groups(List<int> groupIndices) {
     List<String> out = [];
-    groups.forEach((int group) => out.add(_groups[group]));
+    groupIndices.forEach((int groupIndex) => out.add(_groups[groupIndex]));
     return out;
   }
 }
 
 class _AllMatchesIterable implements Iterable<Match> {
   final JSSyntaxRegExp _re;
   final String _str;
 
   const _AllMatchesIterable(this._re, this._str);
 
   Iterator<Match> iterator() => new _AllMatchesIterator(_re, _str);
 }
 
 class _AllMatchesIterator implements Iterator<Match> {
   final RegExp _re;
   final String _str;
   Match _next;
   bool _done;
 
   _AllMatchesIterator(JSSyntaxRegExp re, String this._str)
     : _done = false, _re = re._global;
 
   Match next() {
     if (!hasNext()) {
       throw const NoMoreElementsException();
     }
 
     // _next is set by #hasNext
-    var next = _next;
+    var result = _next;
     _next = null;
-    return next;
+    return result;
   }
 
   bool hasNext() {
     if (_done) {
       return false;
     } else if (_next != null) {
       return true;
     }
 
     _next = _re.firstMatch(_str);
@@ skipping 107 matching lines @@
     } else if (isNaN()) {
       if (other.isNaN()) {
         return 0;
       }
       return 1;
     } else {
       return -1;
     }
   }
 }