Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 9963008: Ensure that arguments object is materialized when deoptimizing from inlined function. (Closed)

Created:
8 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Ensure that arguments object is materialized when deoptimizing from inlined function. Lithium translation rebuilds hydrogen environments from scratch so we have to ensure that arguments object is correctly bound on function entry otherwise deoptimization will not materialize it. This fix was implemented as part of r11109 and then reverted. R=danno@chromium.org BUG=v8:2045 TEST=test/mjsunit/regress/regress-2045.js Committed: https://code.google.com/p/v8/source/detail?r=11194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -3 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +7 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-2045.js View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 8 months ago (2012-03-30 12:41:44 UTC) #1
danno
8 years, 8 months ago (2012-03-30 13:21:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698