samples/third_party/dromaeo/tests/dom-query-html.dart - Issue 9963004: Use the new syntax for native methods that are just renames of other native methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/third_party/dromaeo/tests/dom-query-html.dart

Issue 9963004: Use the new syntax for native methods that are just renames of other native methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Ready to review... Sra's change actually fixed a failing test instead of causing a new test to fail! Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samples/third_party/dromaeo/tests/dom-query-html.dart

diff --git a/samples/third_party/dromaeo/tests/dom-query-html.dart b/samples/third_party/dromaeo/tests/dom-query-html.dart

index 46530d6b177f8ad5ad029d321338cfef53ccf716..c87577fedebbd6e1af82543e9f0c2c543cb13f5a 100644

--- a/samples/third_party/dromaeo/tests/dom-query-html.dart

+++ b/samples/third_party/dromaeo/tests/dom-query-html.dart

@@ -74,7 +74,7 @@ void main() {

.test('getElementsByTagName (not in document)', () {

for (int i = 0; i < num; i++) {

NodeList elems = document.$dom_getElementsByTagName('strong');

- ret = elems.last().$dom_nodeType;

+ ret = elems.length == 0;

}

})

.test('getElementsByName', () {

« no previous file with comments | « lib/html/frog/html_frog.dart ('k') | samples/third_party/dromaeo/tests/dom-query-htmlidiomatic.dart » ('j') | no next file with comments »