chrome/browser/favicon/favicon_service_factory.h - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_service_factory.h

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fixes; remove useless code. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/favicon/fallback_icon_service_factory.cc ('k') | chrome/browser/search/instant_service.cc » ('j') | chrome/browser/ui/webui/fallback_icon_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/favicon/favicon_service_factory.h

diff --git a/chrome/browser/favicon/favicon_service_factory.h b/chrome/browser/favicon/favicon_service_factory.h

index 36157bbb4f1af1c16212d0529a20c152e59bedd4..f62e408bd597348409cbc2710c0a8b38326d579a 100644

--- a/chrome/browser/favicon/favicon_service_factory.h

+++ b/chrome/browser/favicon/favicon_service_factory.h

@@ -18,7 +18,7 @@ class Profile;

// Profiles.

class FaviconServiceFactory : public BrowserContextKeyedServiceFactory {

public:

- // |access| defines what the caller plans to do with the service. See

+ // |sat| defines what the caller plans to do with the service. See

// the ServiceAccessType definition in profile.h.

static FaviconService* GetForProfile(Profile* profile, ServiceAccessType sat);