Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/favicon/core/fallback_icon_client.h

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup; moving defensive code into FallbackIconSource and LargeIconSource. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/fallback_icon_client.h
diff --git a/components/favicon/core/fallback_icon_client.h b/components/favicon/core/fallback_icon_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..0af0adf5780daa8655a66069d80e122a91fb02fa
--- /dev/null
+++ b/components/favicon/core/fallback_icon_client.h
@@ -0,0 +1,34 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_FAVICON_CORE_FALLBACK_ICON_CLIENT_H_
+#define COMPONENTS_FAVICON_CORE_FALLBACK_ICON_CLIENT_H_
+
+#include <string>
+#include <vector>
+
+#include "base/strings/string16.h"
+#include "components/keyed_service/core/keyed_service.h"
+
+class GURL;
+
+namespace favicon_base {
+class FallbackIconService;
pkotwicz 2015/03/27 03:52:09 Can you remove the forward declaration?
huangs 2015/03/27 17:33:07 Done.
+}
+
+// This class abstracts operations that depend on the embedder's environment,
+// e.g. Chrome.
+class FallbackIconClient : public KeyedService {
+ public:
+ // Returns a list of font names for fallback icon rendering.
+ virtual const std::vector<std::string>& GetFontNameList() const = 0;
+
+ // Returns the text to render in fallback icon for |url|.
+ virtual base::string16 GetFallbackIconText(const GURL& url) const = 0;
+
+ protected:
+ ~FallbackIconClient() override {}
+};
+
+#endif // COMPONENTS_FAVICON_CORE_FALLBACK_ICON_CLIENT_H_

Powered by Google App Engine
This is Rietveld 408576698