Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: components/favicon.gypi

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing FallbackIconSource::SendNotFoundResponse(). Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/favicon/core 8 # GN version: //components/favicon/core
9 'target_name': 'favicon_core', 9 'target_name': 'favicon_core',
10 'type': 'static_library', 10 'type': 'static_library',
11 'dependencies': [ 11 'dependencies': [
12 '../skia/skia.gyp:skia', 12 '../skia/skia.gyp:skia',
13 '../ui/gfx/gfx.gyp:gfx', 13 '../ui/gfx/gfx.gyp:gfx',
14 '../url/url.gyp:url_lib', 14 '../url/url.gyp:url_lib',
15 'bookmarks_browser', 15 'bookmarks_browser',
16 'favicon_base', 16 'favicon_base',
17 'history_core_browser', 17 'history_core_browser',
18 'keyed_service_core', 18 'keyed_service_core',
19 ], 19 ],
20 'sources': [ 20 'sources': [
21 # Note: sources list duplicated in GN build. 21 # Note: sources list duplicated in GN build.
22 'favicon/core/fallback_icon_client.h',
22 'favicon/core/fallback_icon_service.cc', 23 'favicon/core/fallback_icon_service.cc',
23 'favicon/core/fallback_icon_service.h', 24 'favicon/core/fallback_icon_service.h',
24 'favicon/core/favicon_client.h', 25 'favicon/core/favicon_client.h',
25 'favicon/core/favicon_driver.h', 26 'favicon/core/favicon_driver.h',
26 'favicon/core/favicon_handler.cc', 27 'favicon/core/favicon_handler.cc',
27 'favicon/core/favicon_handler.h', 28 'favicon/core/favicon_handler.h',
28 'favicon/core/favicon_service.cc', 29 'favicon/core/favicon_service.cc',
29 'favicon/core/favicon_service.h', 30 'favicon/core/favicon_service.h',
30 'favicon/core/favicon_tab_helper_observer.h', 31 'favicon/core/favicon_tab_helper_observer.h',
31 'favicon/core/favicon_url.cc', 32 'favicon/core/favicon_url.cc',
(...skipping 23 matching lines...) Expand all
55 'favicon/content/favicon_url_util.cc', 56 'favicon/content/favicon_url_util.cc',
56 ], 57 ],
57 'include_dirs': [ 58 'include_dirs': [
58 '..', 59 '..',
59 ], 60 ],
60 }, 61 },
61 ], 62 ],
62 }], 63 }],
63 ], 64 ],
64 } 65 }
OLDNEW
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698