Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: chrome/browser/favicon/favicon_service_factory.h

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment fix; removing usage of Profile in factories. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_
7 7
8 #include "base/memory/singleton.h" 8 #include "base/memory/singleton.h"
9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h" 9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"
10 #include "components/keyed_service/core/service_access_type.h" 10 #include "components/keyed_service/core/service_access_type.h"
11 11
12 template <typename T> struct DefaultSingletonTraits; 12 template <typename T> struct DefaultSingletonTraits;
13 13
14 class FaviconService; 14 class FaviconService;
15 class Profile; 15 class Profile;
16 16
17 // Singleton that owns all FaviconService and associates them with 17 // Singleton that owns all FaviconService and associates them with
18 // Profiles. 18 // Profiles.
19 class FaviconServiceFactory : public BrowserContextKeyedServiceFactory { 19 class FaviconServiceFactory : public BrowserContextKeyedServiceFactory {
20 public: 20 public:
21 // |access| defines what the caller plans to do with the service. See 21 // |sat| defines what the caller plans to do with the service. See
22 // the ServiceAccessType definition in profile.h. 22 // the ServiceAccessType definition in profile.h.
23 static FaviconService* GetForProfile(Profile* profile, ServiceAccessType sat); 23 static FaviconService* GetForProfile(Profile* profile, ServiceAccessType sat);
24 24
25 static FaviconServiceFactory* GetInstance(); 25 static FaviconServiceFactory* GetInstance();
26 26
27 private: 27 private:
28 friend struct DefaultSingletonTraits<FaviconServiceFactory>; 28 friend struct DefaultSingletonTraits<FaviconServiceFactory>;
29 29
30 FaviconServiceFactory(); 30 FaviconServiceFactory();
31 ~FaviconServiceFactory() override; 31 ~FaviconServiceFactory() override;
32 32
33 // BrowserContextKeyedServiceFactory: 33 // BrowserContextKeyedServiceFactory:
34 KeyedService* BuildServiceInstanceFor( 34 KeyedService* BuildServiceInstanceFor(
35 content::BrowserContext* profile) const override; 35 content::BrowserContext* profile) const override;
36 bool ServiceIsNULLWhileTesting() const override; 36 bool ServiceIsNULLWhileTesting() const override;
37 37
38 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory); 38 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);
39 }; 39 };
40 40
41 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_ 41 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698