components/favicon/core/DEPS - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon/core/DEPS

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup; moving defensive code into FallbackIconSource and LargeIconSource. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/large_icon_source.cc ('K') | « components/favicon/core/BUILD.gn ('k') | components/favicon/core/fallback_icon_client.h » ('j') | components/favicon/core/fallback_icon_client.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/bookmarks/browser",	2 "+components/bookmarks/browser",

3 "+components/history/core/browser",	3 "+components/history/core/browser",

4 "+components/keyed_service/core",	4 "+components/keyed_service/core",

5 "+net/base/registry_controlled_domains/registry_controlled_domain.h",

6 "+skia",	5 "+skia",

7 "+third_party/skia",	6 "+third_party/skia",

8 "+third_party/skia/include",	7 "+third_party/skia/include",

9 "+ui/gfx",	8 "+ui/gfx",

10 ]	9 ]

OLD	NEW