Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: chrome/browser/favicon/DEPS

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup; moving defensive code into FallbackIconSource and LargeIconSource. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Favicon is being made into a Browser Component, so we have these 2 # Favicon is being made into a Browser Component, so we have these
3 # three basic rules followed by temporary exceptions. Please don't 3 # three basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/chrome_notification_types.h", 6 "+chrome/browser/chrome_notification_types.h",
7 "+chrome/browser/common", 7 "+chrome/browser/common",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 9
10 # Permanently-allowed DEPS beyond the standard Browser 10 # Permanently-allowed DEPS beyond the standard Browser
11 # Components-like DEPS above go here. 11 # Components-like DEPS above go here.
12 "+chrome/browser/profiles/incognito_helpers.h", 12 "+chrome/browser/profiles/incognito_helpers.h",
13 "+chrome/browser/search/search.h", 13 "+chrome/browser/search/search.h",
14 "+components/favicon/core", 14 "+components/favicon/core",
15 "+net/base/registry_controlled_domains/registry_controlled_domain.h",
15 "+third_party/skia/include/core/SkBitmap.h", 16 "+third_party/skia/include/core/SkBitmap.h",
16 17
17 # TODO(caitkp): Bring this list to zero. 18 # TODO(caitkp): Bring this list to zero.
18 # 19 #
19 # Do not add to the list of temporarily-allowed dependencies below, 20 # Do not add to the list of temporarily-allowed dependencies below,
20 # and please do not introduce more #includes of these files. 21 # and please do not introduce more #includes of these files.
21 "!chrome/browser/bookmarks/bookmark_model_factory.h", 22 "!chrome/browser/bookmarks/bookmark_model_factory.h",
22 "!chrome/browser/history/history_backend.h", 23 "!chrome/browser/history/history_backend.h",
23 "!chrome/browser/history/history_service.h", 24 "!chrome/browser/history/history_service.h",
24 "!chrome/browser/history/history_service_factory.h", 25 "!chrome/browser/history/history_service_factory.h",
25 "!chrome/browser/history/select_favicon_frames.h", 26 "!chrome/browser/history/select_favicon_frames.h",
26 "!chrome/browser/profiles/profile.h", 27 "!chrome/browser/profiles/profile.h",
27 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h", 28 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h",
28 "!components/bookmarks/browser/bookmark_model.h", 29 "!components/bookmarks/browser/bookmark_model.h",
29 # Do not add to the list of temporarily-allowed dependencies above, 30 # Do not add to the list of temporarily-allowed dependencies above,
30 # and please do not introduce more #includes of these files. 31 # and please do not introduce more #includes of these files.
31 ] 32 ]
32 33
33 specific_include_rules = { 34 specific_include_rules = {
34 # Browser tests, by definition, need access to the browser objects. 35 # Browser tests, by definition, need access to the browser objects.
35 '.*_browsertest\.cc': [ 36 '.*_browsertest\.cc': [
36 "+chrome/browser", 37 "+chrome/browser",
37 ] 38 ]
38 } 39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698