tools/metrics/histograms/histograms.xml - Issue 996213005: Don't crash when trying to create an ExtensionSyncData from invalid SyncData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 996213005: Don't crash when trying to create an ExtensionSyncData from invalid SyncData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: kalmanize Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index aa061209bc5262ff46c0cc4311f46b985a4cbcbf..b22a5f915890ba1aa1aa126b06aa0afb6ff5b136 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -8461,6 +8461,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Extensions.BadSyncDataReason" enum="BadSyncDataReason">

+ <owner>yoz@chromium.org</owner>

+ <summary>

+ The reason a valid ExtensionSyncData could not be parsed from a SyncData

+ received from sync.

+ </summary>

+</histogram>

<owner>rkaplow@chromium.org</owner>

@@ -44787,6 +44795,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</enum>

+<enum name="BadSyncDataReason" type="int">

+ <int value="0" label="Bad extension ID"/>

+ <int value="1" label="Bad version"/>

+ <int value="2" label="Bad update URL"/>

+ <int value="3" label="No ExtensionSpecifics"/>

+</enum>

« no previous file with comments | « chrome/browser/extensions/extension_sync_service.cc ('k') | no next file » | no next file with comments »