Don't crash when trying to create an ExtensionSyncData from invalid SyncData.

chrome/browser/extensions/extension_sync_data_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_sync_data.h"
 
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/version.h"
 #include "sync/protocol/extension_specifics.pb.h"
 #include "sync/protocol/sync.pb.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
 namespace {
 
 const char kValidId[] = "abcdefghijklmnopabcdefghijklmnop";
 const char kVersion[] = "1.0.0.1";
 const char kValidUpdateUrl[] =
     "https://clients2.google.com/service/update2/crx";
 const char kName[] = "MyExtension";
 
 // Serializes a protobuf structure (entity specifics) into an ExtensionSyncData
 // and back again, and confirms that the input is the same as the output.
 void ProtobufToSyncDataEqual(const sync_pb::EntitySpecifics& entity) {
   syncer::SyncData sync_data =
       syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
-  ExtensionSyncData extension_sync_data(sync_data);
-  syncer::SyncData output_sync_data = extension_sync_data.GetSyncData();
+  scoped_ptr<ExtensionSyncData> extension_sync_data =
+      ExtensionSyncData::CreateFromSyncData(sync_data);
+  ASSERT_TRUE(extension_sync_data.get());
+  syncer::SyncData output_sync_data = extension_sync_data->GetSyncData();
   const sync_pb::ExtensionSpecifics& output =
       output_sync_data.GetSpecifics().extension();
   const sync_pb::ExtensionSpecifics& input = entity.extension();
 
   // Check for field-by-field quality. It'd be nice if we could use
   // AssertionResults here (instead of EXPECT_EQ) so that we could get valid
   // line numbers, but it's not worth the ugliness of the verbose comparison.
   EXPECT_EQ(input.id(), output.id());
   EXPECT_EQ(input.name(), output.name());
   EXPECT_EQ(input.version(), output.version());
   EXPECT_EQ(input.update_url(), output.update_url());
   EXPECT_EQ(input.enabled(), output.enabled());
   EXPECT_EQ(input.incognito_enabled(), output.incognito_enabled());
   EXPECT_EQ(input.remote_install(), output.remote_install());
   EXPECT_EQ(input.installed_by_custodian(), output.installed_by_custodian());
   EXPECT_EQ(input.has_all_urls_enabled(), output.has_all_urls_enabled());
   if (input.has_all_urls_enabled())
     EXPECT_EQ(input.all_urls_enabled(), output.all_urls_enabled());
 }
 
 // Serializes an ExtensionSyncData into a protobuf structure and back again, and
 // confirms that the input is the same as the output.
 void SyncDataToProtobufEqual(const ExtensionSyncData& input) {
   syncer::SyncData sync_data = input.GetSyncData();
-  ExtensionSyncData output(sync_data);
+  scoped_ptr<ExtensionSyncData> output =
+      ExtensionSyncData::CreateFromSyncData(sync_data);
+  ASSERT_TRUE(output.get());
 
-  EXPECT_EQ(input.id(), output.id());
-  EXPECT_EQ(input.uninstalled(), output.uninstalled());
-  EXPECT_EQ(input.enabled(), output.enabled());
-  EXPECT_EQ(input.incognito_enabled(), output.incognito_enabled());
-  EXPECT_EQ(input.remote_install(), output.remote_install());
-  EXPECT_EQ(input.installed_by_custodian(), output.installed_by_custodian());
-  EXPECT_EQ(input.all_urls_enabled(), output.all_urls_enabled());
-  EXPECT_TRUE(input.version().Equals(output.version()));
-  EXPECT_EQ(input.update_url(), output.update_url());
-  EXPECT_EQ(input.name(), output.name());
+  EXPECT_EQ(input.id(), output->id());
+  EXPECT_EQ(input.uninstalled(), output->uninstalled());
+  EXPECT_EQ(input.enabled(), output->enabled());
+  EXPECT_EQ(input.incognito_enabled(), output->incognito_enabled());
+  EXPECT_EQ(input.remote_install(), output->remote_install());
+  EXPECT_EQ(input.installed_by_custodian(), output->installed_by_custodian());
+  EXPECT_EQ(input.all_urls_enabled(), output->all_urls_enabled());
+  EXPECT_TRUE(input.version().Equals(output->version()));
+  EXPECT_EQ(input.update_url(), output->update_url());
+  EXPECT_EQ(input.name(), output->name());
 }
 
 }  // namespace
 
 class ExtensionSyncDataTest : public testing::Test {
 };
 
 // Tests the conversion process from a protobuf to an ExtensionSyncData and vice
 // versa.
 TEST_F(ExtensionSyncDataTest, ExtensionSyncDataForExtension) {
@@ skipping 49 matching lines @@
 
   extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
   EXPECT_FALSE(extension_specifics->has_all_urls_enabled());
   EXPECT_EQ(ExtensionSyncData::BOOLEAN_UNSET,
             extension_sync_data.all_urls_enabled());
 
   SyncDataToProtobufEqual(extension_sync_data);
 }
 
 }  // namespace extensions