Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 9961014: Add calls to store/retrieve user policy to SessionManagerClient. (Closed)

Created:
8 years, 8 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 8 months ago
Reviewers:
Nikita (slow), satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add calls to store/retrieve user policy to SessionManagerClient. BUG=chromium:87383 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130907

Patch Set 1 #

Patch Set 2 : Fix browser tests. #

Total comments: 2

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -60 lines) Patch
M chrome/browser/chromeos/dbus/mock_session_manager_client.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/dbus/session_manager_client.h View 1 chunk +23 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/dbus/session_manager_client.cc View 1 2 5 chunks +63 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_helper_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Please review.
8 years, 8 months ago (2012-04-04 19:35:58 UTC) #1
satorux1
LGTM with one request: http://codereview.chromium.org/9961014/diff/8/chrome/browser/chromeos/dbus/session_manager_client.cc File chrome/browser/chromeos/dbus/session_manager_client.cc (right): http://codereview.chromium.org/9961014/diff/8/chrome/browser/chromeos/dbus/session_manager_client.cc#newcode178 chrome/browser/chromeos/dbus/session_manager_client.cc:178: virtual void CallStorePolicy(const char* method_name, ...
8 years, 8 months ago (2012-04-04 19:41:15 UTC) #2
Mattias Nissler (ping if slow)
Nikita: friendly ping. http://codereview.chromium.org/9961014/diff/8/chrome/browser/chromeos/dbus/session_manager_client.cc File chrome/browser/chromeos/dbus/session_manager_client.cc (right): http://codereview.chromium.org/9961014/diff/8/chrome/browser/chromeos/dbus/session_manager_client.cc#newcode178 chrome/browser/chromeos/dbus/session_manager_client.cc:178: virtual void CallStorePolicy(const char* method_name, On ...
8 years, 8 months ago (2012-04-05 09:29:13 UTC) #3
Nikita (slow)
8 years, 8 months ago (2012-04-05 11:01:54 UTC) #4
chromeos/login lgtm

Powered by Google App Engine
This is Rietveld 408576698