Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 996033002: Automatically harden splits containing too much nesting. Fix #108. (Closed)

Created:
5 years, 9 months ago by Bob Nystrom
Modified:
5 years, 9 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Automatically harden splits containing too much nesting. Fix #108. R=pquitslund@google.com Committed: 69c2b3cfa607d9bd38df015d51cd1cb5cf6eb1bc

Patch Set 1 #

Patch Set 2 : Update changelog. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -2 lines) Patch
M CHANGELOG.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/line_splitter.dart View 3 chunks +28 lines, -2 lines 2 comments Download
A test/regression/108.unit View 1 chunk +257 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
With this patch (and the previous ones I sent out), I can now reformat the ...
5 years, 9 months ago (2015-03-10 23:49:31 UTC) #2
pquitslund
LGTM. Needless to say this is Rad. https://chromiumcodereview.appspot.com/996033002/diff/20001/lib/src/line_splitter.dart File lib/src/line_splitter.dart (right): https://chromiumcodereview.appspot.com/996033002/diff/20001/lib/src/line_splitter.dart#newcode118 lib/src/line_splitter.dart:118: // TODO(rnystrom): ...
5 years, 9 months ago (2015-03-11 00:09:50 UTC) #3
Bob Nystrom
https://chromiumcodereview.appspot.com/996033002/diff/20001/lib/src/line_splitter.dart File lib/src/line_splitter.dart (right): https://chromiumcodereview.appspot.com/996033002/diff/20001/lib/src/line_splitter.dart#newcode118 lib/src/line_splitter.dart:118: // TODO(rnystrom): Do something smarter. On 2015/03/11 00:09:50, pquitslund ...
5 years, 9 months ago (2015-03-11 00:14:18 UTC) #4
Bob Nystrom
5 years, 9 months ago (2015-03-11 00:14:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
69c2b3cfa607d9bd38df015d51cd1cb5cf6eb1bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698