Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: runtime/lib/string.dart

Issue 9960084: Introduce a flag to disable string operator + (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string.dart
===================================================================
--- runtime/lib/string.dart (revision 6417)
+++ runtime/lib/string.dart (working copy)
@@ -233,11 +233,17 @@
}
/**
+ * TODO(hausner): remove support for operator + and native method plus().
+ */
+ String plus(String other) native "String_plus";
srdjan 2012/04/11 18:32:03 Why not making it private (_plus)?
hausner 2012/04/11 18:36:22 Yes, would have been a good idea. But this code go
+
+ /**
* Convert argument obj to string and concat it with this string.
* Returns concatenated string.
+ * TODO(hausner): remove support for +.
*/
String operator +(Object obj) {
- return this.concat(obj.toString());
+ return this.plus(obj.toString());
}
/**
« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698