Issue 9960083: Add a Flash API to get the device ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9960083: Add a Flash API to get the device ID. (Closed)

Created:
8 years, 8 months ago by brettw

Modified:
8 years, 8 months ago

Reviewers:
raymes

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a Flash API to get the device ID. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132269

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Review comments #

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -37 lines)			Patch
M	ppapi/api/private/ppb_flash.idl	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	ppapi/c/private/ppb_flash.h	View		5 chunks	+36 lines, -4 lines	0 comments	Download
M	ppapi/cpp/private/flash.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/cpp/private/flash.cc	View	1	13 chunks	+95 lines, -31 lines	0 comments	Download
M	ppapi/proxy/interface_list.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.cc	View		3 chunks	+26 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl.cc	View	1 2	3 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

It's ready. I'm going to actually implement the function in a second pass.

8 years, 8 months ago (2012-04-10 23:49:22 UTC) #2

raymes

8 years, 8 months ago (2012-04-11 00:16:11 UTC) #3

LGTM with comments.

https://chromiumcodereview.appspot.com/9960083/diff/1/ppapi/cpp/private/flash.cc
File ppapi/cpp/private/flash.cc (right):

https://chromiumcodereview.appspot.com/9960083/diff/1/ppapi/cpp/private/flash...
ppapi/cpp/private/flash.cc:24: template <> const char*
interface_name<PPB_Flash>() {
In other reviews I've been told to explicitly have
PPB_Flash_12_2/PPB_FLASH_INTERFACE here. Not sure which is the most accepted
style.

https://chromiumcodereview.appspot.com/9960083/diff/1/webkit/plugins/ppapi/pp...
File webkit/plugins/ppapi/ppb_flash_impl.cc (right):

https://chromiumcodereview.appspot.com/9960083/diff/1/webkit/plugins/ppapi/pp...
webkit/plugins/ppapi/ppb_flash_impl.cc:343: }
Should there be GetInterface12_2() here?

Expand Messages | Collapse Messages