Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8702)

Unified Diff: chrome/service/cloud_print/print_system_cups.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/print_system_cups.cc
diff --git a/chrome/service/cloud_print/print_system_cups.cc b/chrome/service/cloud_print/print_system_cups.cc
index e3440c788449823c745a82a140f368661b85cf53..cbaf2cd91ac87d3120fa757a9cccf7cce88d596a 100644
--- a/chrome/service/cloud_print/print_system_cups.cc
+++ b/chrome/service/cloud_print/print_system_cups.cc
@@ -510,8 +510,7 @@ bool PrintSystemCUPS::IsValidPrinter(const std::string& printer_name) {
bool PrintSystemCUPS::ValidatePrintTicket(const std::string& printer_name,
const std::string& print_ticket_data) {
DCHECK(initialized_);
- scoped_ptr<Value> ticket_value(base::JSONReader::Read(print_ticket_data,
- false));
+ scoped_ptr<Value> ticket_value(base::JSONReader::Read(print_ticket_data));
return ticket_value != NULL && ticket_value->IsType(Value::TYPE_DICTIONARY);
}
@@ -520,7 +519,7 @@ bool PrintSystemCUPS::ParsePrintTicket(
const std::string& print_ticket,
std::map<std::string, std::string>* options) {
DCHECK(options);
- scoped_ptr<Value> ticket_value(base::JSONReader::Read(print_ticket, false));
+ scoped_ptr<Value> ticket_value(base::JSONReader::Read(print_ticket));
if (ticket_value == NULL || !ticket_value->IsType(Value::TYPE_DICTIONARY))
return false;

Powered by Google App Engine
This is Rietveld 408576698