Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8317)

Unified Diff: chrome/common/extensions/simple_feature_provider.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/simple_feature_provider.cc
diff --git a/chrome/common/extensions/simple_feature_provider.cc b/chrome/common/extensions/simple_feature_provider.cc
index 63741aa755b037961ef9eb3e781c720e26cbc8a9..08bed3131f5592d8f6779edbc0a3c40599b6810e 100644
--- a/chrome/common/extensions/simple_feature_provider.cc
+++ b/chrome/common/extensions/simple_feature_provider.cc
@@ -15,8 +15,6 @@ namespace extensions {
namespace {
-const bool kAllowTrailingComma = false;
-
template<class FeatureClass>
Feature* CreateFeature() {
return new FeatureClass();
@@ -48,7 +46,8 @@ struct Static {
int error_code = 0;
std::string error_message;
Value* value = base::JSONReader::ReadAndReturnError(
- manifest_features, kAllowTrailingComma, &error_code, &error_message);
+ manifest_features, base::JSON_PARSE_RFC,
+ &error_code, &error_message);
CHECK(value) << "Could not load features: " << debug_string << " "
<< error_message;
CHECK(value->IsType(Value::TYPE_DICTIONARY)) << debug_string;

Powered by Google App Engine
This is Rietveld 408576698