chrome/common/cloud_print/cloud_print_helpers.cc - Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/cloud_print/cloud_print_helpers.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/json/json_reader.h ('K') | « chrome/browser/web_resource/promo_resource_service_unittest.cc ('k') | chrome/common/extensions/api/extension_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/cloud_print/cloud_print_helpers.cc

diff --git a/chrome/common/cloud_print/cloud_print_helpers.cc b/chrome/common/cloud_print/cloud_print_helpers.cc

index cebe4a35d372079b401182e8500d602bea417da4..e8f7650bb7f5aa15eb234b8f43642b6348770a2d 100644

--- a/chrome/common/cloud_print/cloud_print_helpers.cc

+++ b/chrome/common/cloud_print/cloud_print_helpers.cc

@@ -47,7 +47,7 @@ GURL GetUrlForSubmit(const GURL& cloud_print_server_url) {

bool ParseResponseJSON(const std::string& response_data,

bool* succeeded,

DictionaryValue** response_dict) {

- scoped_ptr<Value> message_value(base::JSONReader::Read(response_data, false));

+ scoped_ptr<Value> message_value(base::JSONReader::Read(response_data));

if (!message_value.get())

return false;

« base/json/json_reader.h ('K') | « chrome/browser/web_resource/promo_resource_service_unittest.cc ('k') | chrome/common/extensions/api/extension_api.cc » ('j') | no next file with comments »