chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc - Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/json/json_reader.h ('K') | « chrome/browser/policy/configuration_policy_handler_chromeos.cc ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc b/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

index 27bd89387f72c2a6b320261b1f5e3121ac3a1d30..fb34458d648c9dd507af1b949aa4187b3f44d28b 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

@@ -36,7 +36,7 @@ void CloudPrintSetupMessageHandler::HandleSubmitAuth(const ListValue* args) {

return;

}

- scoped_ptr<Value> parsed_value(base::JSONReader::Read(json, false));

+ scoped_ptr<Value> parsed_value(base::JSONReader::Read(json));

if (!parsed_value.get() || !parsed_value->IsType(Value::TYPE_DICTIONARY)) {

NOTREACHED() << "Unable to parse auth data";

return;

« base/json/json_reader.h ('K') | « chrome/browser/policy/configuration_policy_handler_chromeos.cc ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | no next file with comments »