Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: chrome/browser/extensions/extension_menu_manager_unittest.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_menu_manager_unittest.cc
diff --git a/chrome/browser/extensions/extension_menu_manager_unittest.cc b/chrome/browser/extensions/extension_menu_manager_unittest.cc
index 7fc9ff325d1a712ff4756fb74cd3e4b89ffc4f68..cae9a9bcea1ae12f4cddaade8c08c64c3bbc2a56 100644
--- a/chrome/browser/extensions/extension_menu_manager_unittest.cc
+++ b/chrome/browser/extensions/extension_menu_manager_unittest.cc
@@ -467,7 +467,8 @@ TEST_F(ExtensionMenuManagerTest, ExecuteCommand) {
// Parse the json event_args, which should turn into a 2-element list where
// the first element is a dictionary we want to inspect for the correct
// values.
- scoped_ptr<Value> result(base::JSONReader::Read(event_args, true));
+ scoped_ptr<Value> result(
+ base::JSONReader::Read(event_args, base::JSON_ALLOW_TRAILING_COMMAS));
Value* value = result.get();
ASSERT_TRUE(result.get() != NULL);
ASSERT_EQ(Value::TYPE_LIST, value->GetType());

Powered by Google App Engine
This is Rietveld 408576698