chrome/browser/extensions/extension_debugger_api.cc - Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_debugger_api.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/json/json_reader.h ('K') | « chrome/browser/extensions/chrome_app_api_browsertest.cc ('k') | chrome/browser/extensions/extension_function_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_debugger_api.cc

diff --git a/chrome/browser/extensions/extension_debugger_api.cc b/chrome/browser/extensions/extension_debugger_api.cc

index 5bf283b176fc70a1a1e17db02064ce84409ebdf8..646eb0f905b27a54e0819e2231f608e5cae56c21 100644

--- a/chrome/browser/extensions/extension_debugger_api.cc

+++ b/chrome/browser/extensions/extension_debugger_api.cc

@@ -283,7 +283,7 @@ void ExtensionDevToolsClientHost::DispatchOnInspectorFrontend(

if (profile == NULL || !profile->GetExtensionEventRouter())

return;

- scoped_ptr<Value> result(base::JSONReader::Read(message, false));

+ scoped_ptr<Value> result(base::JSONReader::Read(message));

if (!result->IsType(Value::TYPE_DICTIONARY))

return;

DictionaryValue* dictionary = static_cast<DictionaryValue*>(result.get());