chrome/browser/extensions/app_notification_storage.cc - Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_notification_storage.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/json/json_reader.h ('K') | « chrome/browser/content_settings/host_content_settings_map_unittest.cc ('k') | chrome/browser/extensions/app_notify_channel_setup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_notification_storage.cc

diff --git a/chrome/browser/extensions/app_notification_storage.cc b/chrome/browser/extensions/app_notification_storage.cc

index 914f997b077b30cc94975bffc61cfa1d6ae1d864..42f11b2b2feff3f8947801944c23c681bcab4dc7 100644

--- a/chrome/browser/extensions/app_notification_storage.cc

+++ b/chrome/browser/extensions/app_notification_storage.cc

@@ -80,8 +80,7 @@ void AppNotificationListToJSON(const AppNotificationList& list,

bool JSONToAppNotificationList(const std::string& json,

AppNotificationList* list) {

CHECK(list);

- scoped_ptr<Value> value(JSONReader::Read(json,

- false /* allow_trailing_comma */));

+ scoped_ptr<Value> value(JSONReader::Read(json));

if (!value.get() || value->GetType() != Value::TYPE_LIST)

return false;