Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/common/net/gaia/oauth2_access_token_fetcher.cc

Issue 9960077: Modify the base::JSONReader interface to take a set of options rather than a boolean flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/net/gaia/oauth2_access_token_fetcher.h" 5 #include "chrome/common/net/gaia/oauth2_access_token_fetcher.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 } 198 }
199 199
200 // static 200 // static
201 bool OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse( 201 bool OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse(
202 const URLFetcher* source, 202 const URLFetcher* source,
203 std::string* access_token) { 203 std::string* access_token) {
204 CHECK(source); 204 CHECK(source);
205 CHECK(access_token); 205 CHECK(access_token);
206 std::string data; 206 std::string data;
207 source->GetResponseAsString(&data); 207 source->GetResponseAsString(&data);
208 base::JSONReader reader; 208 scoped_ptr<base::Value> value(base::JSONReader::Read(data));
209 scoped_ptr<base::Value> value(reader.Read(data, false));
210 if (!value.get() || value->GetType() != base::Value::TYPE_DICTIONARY) 209 if (!value.get() || value->GetType() != base::Value::TYPE_DICTIONARY)
211 return false; 210 return false;
212 211
213 DictionaryValue* dict = static_cast<DictionaryValue*>(value.get()); 212 DictionaryValue* dict = static_cast<DictionaryValue*>(value.get());
214 return GetStringFromDictionary(dict, kAccessTokenKey, access_token); 213 return GetStringFromDictionary(dict, kAccessTokenKey, access_token);
215 } 214 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698