Issue 9960065: Do not assume that names of function expressions are context-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9960065: Do not assume that names of function expressions are context-allocated. (Closed)

Created:
8 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
8 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Do not assume that names of function expressions are context-allocated. The heap profile generator assumes that for named function expressions, the name is context allocated. This is not necessary true. BUG=v8:2051 TEST=WebKit layout test inspector/profiler/heap-snapshot-inspect-dom-wrapper.html Committed: https://code.google.com/p/v8/source/detail?r=11251

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	src/objects.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/profile-generator.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages