Issue 9960060: Handle-passing: Allow a handle-passing function to be supplied by Chromium

Issue 9960060: Handle-passing: Allow a handle-passing function to be supplied by Chromium (Closed)

Created:
8 years, 8 months ago by Mark Seaborn

Modified:
8 years, 8 months ago

Reviewers:
bsy, sehr (please use chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Windows: Allow a handle-passing function to be supplied by Chromium This will allow the NaCl trusted plugin and the NaCl loader process to use a handle-passing function supplied by the Chrome sandbox. In turn, this will allow the sandbox to be locked down more. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719 TEST=sel_main_chrome_test, plus tested by building Chromium on Windows Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8221

Patch Set 1 #

Patch Set 2 : Hook up via sel_main_chrome.h #

Patch Set 3 : Add "broker" prefix to name #

Total comments: 4

Patch Set 4 : Put #ifs at end of NaClChromeMainArgs for neatness #

Patch Set 5 : Review #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -10 lines)			Patch
M	src/shared/imc/nacl_imc_c.h	View	1 2 3 4	1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/shared/imc/win/nacl_imc.cc	View	1 2 3 4	3 chunks	+37 lines, -10 lines	0 comments	Download
M	src/trusted/service_runtime/sel_main_chrome.h	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/trusted/service_runtime/sel_main_chrome.c	View	1 2 3	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

The corresponding Chrome-side change is https://chromiumcodereview.appspot.com/10039001 (which isn't finished yet).

8 years, 8 months ago (2012-04-10 16:40:38 UTC) #1

Mark Seaborn

I've added a "Broker" prefix to the function name to make it clearer that it ...

8 years, 8 months ago (2012-04-10 18:57:19 UTC) #2

sehr (please use chromium)

A couple of nits. Fix and LGTM. http://codereview.chromium.org/9960060/diff/8/src/shared/imc/nacl_imc_c.h File src/shared/imc/nacl_imc_c.h (right): http://codereview.chromium.org/9960060/diff/8/src/shared/imc/nacl_imc_c.h#newcode248 src/shared/imc/nacl_imc_c.h:248: uint32_t process_id, ...

8 years, 8 months ago (2012-04-10 21:27:35 UTC) #3

Mark Seaborn

8 years, 8 months ago (2012-04-10 21:47:23 UTC) #4

I've also moved the #ifs to the end of struct NaClChromeMainArgs so that it will
be easier to keep platform-specific things together in the future when there are
more of them.

https://chromiumcodereview.appspot.com/9960060/diff/8/src/shared/imc/nacl_imc...
File src/shared/imc/nacl_imc_c.h (right):

https://chromiumcodereview.appspot.com/9960060/diff/8/src/shared/imc/nacl_imc...
src/shared/imc/nacl_imc_c.h:248: uint32_t process_id,
On 2012/04/10 21:27:35, sehr wrote:
> perhaps "target_process_id" just for emphasis.

Done.

https://chromiumcodereview.appspot.com/9960060/diff/8/src/shared/imc/win/nacl...
File src/shared/imc/win/nacl_imc.cc (right):

https://chromiumcodereview.appspot.com/9960060/diff/8/src/shared/imc/win/nacl...
src/shared/imc/win/nacl_imc.cc:30: static NaClBrokerDuplicateHandleFunc
g_broker_duplicate_handle_func;
On 2012/04/10 21:27:35, sehr wrote:
> I think the general preference is for an anonymous namespace rather than
> file-scoped statics.

Done.

Expand Messages | Collapse Messages