Finish separation of testing from sel_ldr validation. Also, automate

src/trusted/validator_arm/inst_classes.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_ARM_V2_INST_CLASSES_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_ARM_V2_INST_CLASSES_H_
 
 #include <stdint.h>
@@ skipping 238 matching lines @@
   // *more* bits to be clear to set Z.  This is fine.
   virtual bool sets_Z_if_bits_clear(Instruction i,
                                     Register r,
                                     uint32_t mask) const {
     UNREFERENCED_PARAMETER(i);
     UNREFERENCED_PARAMETER(r);
     UNREFERENCED_PARAMETER(mask);
     return false;
   }
 
-  // Returns a c-string containing the name of the class. Used for
-  // testing only.
-  virtual const char* name() const;
-
   // Many instructions define control bits in bits 20-24. The useful bits
   // are defined here.
 
   // True if U (updates flags register) flag is defined.
   inline bool UpdatesFlagsRegister(const Instruction& i) const {
     return i.bit(20);
   }
 
   // True if W (does write) flag is defined.
   inline bool WritesFlag(const Instruction& i) const {
@@ skipping 303 matching lines @@
   const RegNBits16To19Interface n_;
   const UpdatesFlagsRegisterBit20Interface flags_;
   const ConditionBits28To31Interface cond_;
 
   // Methods for class.
   Binary3RegisterShiftedTest()
       : ClassDecoder(), m_(), s_(), n_(), flags_(), cond_() {}
   virtual ~Binary3RegisterShiftedTest() {}
   virtual SafetyLevel safety(Instruction i) const;
   virtual RegisterList defs(Instruction i) const;
+
  private:
   // Don't allow the following!
   explicit Binary3RegisterShiftedTest(const Binary3RegisterShiftedTest&);
   Binary3RegisterShiftedTest& operator=(const Binary3RegisterShiftedTest&);
 };
 
 // Models the few data-processing instructions that *don't* produce a result,
 // but may still set flags.
 //
 // Includes:
@@ skipping 561 matching lines @@
   virtual bool is_relative_branch(Instruction i) const {
     UNREFERENCED_PARAMETER(i);
     return true;
   }
   virtual int32_t branch_target_offset(Instruction i) const;
 };
 
 }  // namespace
 
 #endif  // NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_ARM_V2_INST_CLASSES_H_