Finish separation of testing from sel_ldr validation. Also, automate

src/trusted/validator_arm/dgen_input.py

 #!/usr/bin/python
 #
-# Copyright 2012 The Native Client Authors.  All rights reserved.
-# Use of this source code is governed by a BSD-style license that can
-# be found in the LICENSE file.
+# Copyright (c) 2012 The Native Client Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
 #
 
 """
 A simple recursive-descent parser for the table file format.
 
 The grammar implemented here is roughly (taking some liberties with whitespace
 and comment parsing):
 
 table_file ::= ( BLANK_LINE | table_def ) end_of_file ;
 table_def ::= "--" IDENT CITATION NL
     table_header
     ( table_row )+ ;
 table_header ::= ( IDENT "(" BITRANGE ")" )+ ;
 table_row ::= ( PATTERN )+ ACTION ;
 
 IDENT = /[a-z0-9_]+/
 CITATION = "(" /[^)]+/ ")"
 BITRANGE = /[0-9]+/ (":" /[0-9]+/)?
 PATTERN = /[10x_]+/
-ACTION = ( "=" IDENT | "->" IDENT ) ( "(" IDENT ")" )?
+ACTION = ( "=" IDENT | "->" IDENT ) ( "(" IDENT ")" )? IDENT*
 NL = a newline
 BLANK_LINE = what you might expect it to be
+
+If ACTION has more than one IDENT, the interpretation is as follows:
+   IDENT[0] = action (plus optional architecture) to apply.
+   IDENT[1] = Arm rule action corresponds to.
+   IDENT[2] = Bit pattern of rule.
+   IDENT[3] = Name defining additional constraints for match.
 """
 
 import re
 import dgen_core
 
 # These globals track the parser state.
 _in = None
 _line_no = None
 _tables = None
 _line = None
@@ skipping 48 matching lines @@
 
         hi_bit = int(m.group(2))
         if m.group(4):
             lo_bit = int(m.group(4))
         else:
             lo_bit = hi_bit
         table.add_column(m.group(1), hi_bit, lo_bit)
     next_line()
 
 
 def table_row(table):

[robertm, 2012/04/11 01:28:43]

can you add a docstring and maybe a sample line or two of what this tried to
parse

[Karl, 2012/04/16 23:18:10]

Did this in general. This file has gone through major revision.

     global _last_row
 
     row = _line.split()
     for i in range(0, len(row)):
         if row[i] == '"': row[i] = _last_row[i]
     _last_row = row
 
-    action = row[-1]
-    patterns = row[:-1]
-    table.add_row(patterns, action)
+    # Pull out action and set of following symbols, and
+    # remerge them into a single string operation (separated
+    # by a single space).
+    action_index = 0
+    action_type = None
+    for w in row:
+      if w.startswith('='):
+        action_type = '='
+        break;
+      elif w.startswith('->'):
+        action_type = '->'
+        break;
+      else:
+        action_index += 1
+
+    # verify we have a properly defined input.
+    if action_index == len(row): unexpected()
+
+    action = row[action_index:]
+    patterns = row[:action_index]
+
+    # verify we don't have too many fields for an action.
+    if len(action) > 4: unexpected()
+    if action_type == '->' and len(action) != 1: unexpected()
+
+    # Recompose the action into a single token and add.
+    table.add_row(patterns, ' '.join(action))
     next_line()
 
 
 def end_of_file():
     return _line is None
 
 
 def next_line():
-    "Reads the next non-comment line"
+    """Reads the next non-comment line"""
     global _line_no, _line
 
     _line_no += 1
     _line = _in.readline()
     while True:
       if _line:
-        if _line[0] == '#':
+        if _line.startswith("#"):
           # skip comment line and continue search.
           _line_no += 1
           _line = _in.readline()
           continue
         _line = re.sub(r'#.*', '', _line).strip()

[robertm, 2012/04/11 01:28:43]

does this line sill make sense, since you are already processing comments in the
block above?

[Karl, 2012/04/16 23:18:10]

Since the parser is now free-form, it is no longer necessary to play games
around commented and empty lines. The new code for reading lines is greatly
simplified.

+        if _line.endswith('\\'):
+          # continuation. continue on next line.
+          _line_no += 1
+          _line = _line[:-1] + ' ' + _in.readline()
+          continue
       else:
         _line = None
       # if reached, found line.
       return
 
+
 def unexpected():
     raise Exception('Line %d: Unexpected line in input: %s' % (_line_no, _line))