media/audio/mac/audio_output_mac.cc - Issue 9959137: Replace NOTREACHED() with LOG(ERROR) in PCMQueueOutAudioOutputStream::HandleError().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/mac/audio_output_mac.cc

Issue 9959137: Replace NOTREACHED() with LOG(ERROR) in PCMQueueOutAudioOutputStream::HandleError(). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/mac/audio_output_mac.cc

diff --git a/media/audio/mac/audio_output_mac.cc b/media/audio/mac/audio_output_mac.cc

index 06fc26fda67bf606ef452d53dc60c5bf0a52b975..8328a0111311ca86e1ed4d662c9bf43b562dfcf5 100644

--- a/media/audio/mac/audio_output_mac.cc

+++ b/media/audio/mac/audio_output_mac.cc

@@ -98,8 +98,8 @@ void PCMQueueOutAudioOutputStream::HandleError(OSStatus err) {

AudioSourceCallback* source = GetSource();

if (source)

source->OnError(this, static_cast<int>(err));

- NOTREACHED() << "error " << GetMacOSStatusErrorString(err)

- << " (" << err << ")";

+ LOG(ERROR) << "error " << GetMacOSStatusErrorString(err)

+ << " (" << err << ")";

}

bool PCMQueueOutAudioOutputStream::Open() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »