Issue 9959137: Replace NOTREACHED() with LOG(ERROR) in PCMQueueOutAudioOutputStream::HandleError().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9959137: Replace NOTREACHED() with LOG(ERROR) in PCMQueueOutAudioOutputStream::HandleError(). (Closed)

Created:
8 years, 8 months ago by scherkus (not reviewing)

Modified:
8 years, 8 months ago

Reviewers:
vrk (LEFT CHROMIUM)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace NOTREACHED() with LOG(ERROR) in PCMQueueOutAudioOutputStream::HandleError(). BUG=109441 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130761

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	media/audio/mac/audio_output_mac.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/9959137/1

8 years, 8 months ago (2012-04-04 03:06:47 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-04 09:15:06 UTC) #4

Try job failure for 9959137-1 (retry) (retry) (retry) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages