Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/ui/cocoa/task_manager_mac_unittest.mm

Issue 9959101: Exposing the child process unique ID through the task manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improved the comment on the new function in TaskManagerModel. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm b/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
index 1c958b3420e4e0a587ea9d238cb968dc29a19003..e1d495f80f4a9db5cd129ec3c4ab75379f18c128 100644
--- a/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
@@ -24,6 +24,11 @@ class TestResource : public TaskManager::Resource {
virtual string16 GetProfileName() const OVERRIDE { return string16(); }
virtual SkBitmap GetIcon() const OVERRIDE { return SkBitmap(); }
virtual base::ProcessHandle GetProcess() const OVERRIDE { return pid_; }
+ virtual int GetUniqueChildProcessId() const OVERRIDE {
+ // In reality the unique child process ID is not the actual process ID,
+ // but for testing purposes it shouldn't make difference.
+ return (int) base::GetCurrentProcId();
Mark Mentovai 2012/04/04 18:21:32 Don’t use (C-style)casts, ever, anywhere. Use C++<
nasko 2012/04/04 19:31:24 Done.
+ }
virtual Type GetType() const OVERRIDE { return RENDERER; }
virtual bool SupportNetworkUsage() const OVERRIDE { return false; }
virtual void SetSupportNetworkUsage() OVERRIDE { NOTREACHED(); }

Powered by Google App Engine
This is Rietveld 408576698