Issue 9959097: Move webNavigation extension api into a separate directory

Issue 9959097: Move webNavigation extension api into a separate directory (Closed)

Created:
8 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 8 months ago

Reviewers:
Avi (use Gerrit), battre

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move webNavigation extension api into a separate directory BUG=101244 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130577

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -1660 lines)			Patch
A	chrome/browser/extensions/api/web_navigation/OWNERS	View	1 chunk	+1 line, -0 lines	1 comment	Download
A +	chrome/browser/extensions/api/web_navigation/web_navigation_api.h	View	6 chunks	+17 lines, -15 lines	0 comments	Download
A +	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View	22 chunks	+40 lines, -39 lines	0 comments	Download
A +	chrome/browser/extensions/api/web_navigation/web_navigation_api_constants.h	View	2 chunks	+10 lines, -6 lines	0 comments	Download
A +	chrome/browser/extensions/api/web_navigation/web_navigation_api_constants.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
A +	chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc	View	4 chunks	+7 lines, -4 lines	0 comments	Download
A +	chrome/browser/extensions/api/web_navigation/web_navigation_unittest.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/extensions/extension_webnavigation_api.h	View	1 chunk	+0 lines, -266 lines	0 comments	Download
D	chrome/browser/extensions/extension_webnavigation_api.cc	View	1 chunk	+0 lines, -808 lines	0 comments	Download
D	chrome/browser/extensions/extension_webnavigation_api_constants.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	chrome/browser/extensions/extension_webnavigation_api_constants.cc	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	chrome/browser/extensions/extension_webnavigation_apitest.cc	View	1 chunk	+0 lines, -320 lines	0 comments	Download
D	chrome/browser/extensions/extension_webnavigation_unittest.cc	View	1 chunk	+0 lines, -113 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	4 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Dominic: please review Avi: please rubber stamp the rename in chrome/browser/ui/tab_contents

8 years, 8 months ago (2012-04-03 12:29:33 UTC) #1

battre

LGTM https://chromiumcodereview.appspot.com/9959097/diff/1/chrome/browser/extensions/api/web_navigation/OWNERS File chrome/browser/extensions/api/web_navigation/OWNERS (right): https://chromiumcodereview.appspot.com/9959097/diff/1/chrome/browser/extensions/api/web_navigation/OWNERS#newcode1 chrome/browser/extensions/api/web_navigation/OWNERS:1: jochen@chromium.org do you want to list a second ...

8 years, 8 months ago (2012-04-03 12:44:56 UTC) #2

jochen (gone - plz use gerrit)

On 2012/04/03 12:44:56, battre wrote: > LGTM > > https://chromiumcodereview.appspot.com/9959097/diff/1/chrome/browser/extensions/api/web_navigation/OWNERS > File chrome/browser/extensions/api/web_navigation/OWNERS (right): > ...

8 years, 8 months ago (2012-04-03 12:47:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/9959097/1

8 years, 8 months ago (2012-04-03 14:30:38 UTC) #5

commit-bot: I haz the power

8 years, 8 months ago (2012-04-03 21:23:14 UTC) #6

Try job failure for 9959097-1 (retry) (retry) (retry) on win_rel for steps
"browser_tests, unit_tests".
It's a second try, previously, steps "browser_tests, unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages