Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 9959096: Switch regexp strategy for regexps that are just plain (Closed)

Created:
8 years, 8 months ago by Erik Corry
Modified:
8 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Switch regexp strategy for regexps that are just plain strings with a small alphabet. We already have code that handles these regexps well, we were just not always activating it. Committed: https://code.google.com/p/v8/source/detail?r=11218

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M src/jsregexp.cc View 6 chunks +41 lines, -7 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 8 months ago (2012-04-03 11:27:24 UTC) #1
ulan
8 years, 8 months ago (2012-04-03 11:43:13 UTC) #2
LGTM

https://chromiumcodereview.appspot.com/9959096/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://chromiumcodereview.appspot.com/9959096/diff/1/src/jsregexp.cc#newcode132
src/jsregexp.cc:132: if (different * 3 > length) return false;
A comment explaining '3' would be helpful.

Powered by Google App Engine
This is Rietveld 408576698