Issue 66: closing browser results into "SocketException: Broken pipe"

plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/websocket/Hybi17WsConnection.java

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.sdk.internal.websocket;
 
 import java.io.IOException;
 import java.net.InetSocketAddress;
 import java.util.Random;
 import java.util.logging.Level;
@@ skipping 129 matching lines @@
     sendMessage(OpCode.TEXT, payload, false);
   }
 
   @Override
   protected CloseReason runListenLoop(LoggableInput loggableReader)
       throws IOException, InterruptedException {
     try {
       return runListenLoopImpl(loggableReader);
     } catch (IOException e) {
       String stackTrace = BasicUtil.getStacktraceString(e);
-      sendClosingMessage(StatusCode.PROTOCOL_ERROR, stackTrace);
+      try {
+        sendClosingMessage(StatusCode.PROTOCOL_ERROR, stackTrace);
+      } catch (IOException e2) {
+        // Connection may be closed by this time. We probably don't want to log this exception.
+      }
       throw new IOException(e);
     } catch (IncomingProtocolException e) {
       String stackTrace = BasicUtil.getStacktraceString(e);
       sendClosingMessage(e.getStatusCode(), stackTrace);
       throw new IOException(e);
     }
   }
 
   private CloseReason runListenLoopImpl(LoggableInput loggableReader)
       throws IOException, InterruptedException, IncomingProtocolException {
     while (true) {
       loggableReader.markSeparatorForLog();
       int firstByte;
       try {
         firstByte = loggableReader.readByteOrEos();
       } catch (IOException e) {
         if (isClosingGracefully()) {
           return CloseReason.USER_REQUEST;
         } else {
           throw e;
         }
       }
       if (firstByte == -1) {
         if (isClosingGracefully()) {
           return CloseReason.USER_REQUEST;
         } else {
-          throw new IOException("Unexpected end of stream");
+          return CloseReason.REMOTE_SILENTLY_CLOSED;
         }
       }
 
       if ((firstByte & FrameBits.FIN_BIT) == 0) {
         throw new IncomingProtocolException("Fragments unsupported",
             StatusCode.CANNOT_ACCEPT, null);
       }
       if ((firstByte & FrameBits.RESERVED_MASK) != 0) {
         throw new IncomingProtocolException("Unexpected reserved bits",
             StatusCode.PROTOCOL_ERROR, null);
@@ skipping 192 matching lines @@
     int length = loggablePayload.getLength();
     LoggableOutput output = getSocketWrapper().getLoggableOutput();
 
     byte[] maskBytes = maskStrategy.generate();
 
     synchronized (this) {
       if (isOutputClosed()) {
         throw new IOException("WebSocket is already closed for output");
       }
 
+      if (isClosingMessage) {
+        // Close it before actually sending, because we can fail on it.
+        setOutputClosed(true);
+      }
+
       byte firstByte = (byte) (FrameBits.FIN_BIT | OpCode.TEXT);
 
       output.writeByte(firstByte);
 
       int maskFlag = maskBytes == null ? 0 : FrameBits.MASK_BIT;
 
       if (length <= 125) {
         output.writeByte((byte) (length | maskFlag));
       } else if (length <= FrameBits.MAX_TWO_BYTE_INT) {
         output.writeByte((byte) (FrameBits.LENGTH_2_BYTE_CODE | maskFlag));
         output.writeByte((byte) ((length >> 8) & 0xFF));
         output.writeByte((byte) (length & 0xFF));
       } else {
         output.writeByte((byte) (FrameBits.LENGTH_8_BYTE_CODE | maskFlag));
         output.writeByte((byte) 0);
         output.writeByte((byte) 0);
         output.writeByte((byte) 0);
         output.writeByte((byte) 0);
         output.writeByte((byte) (length >>> 24));
         output.writeByte((byte) ((length >> 16) & 0xFF));
         output.writeByte((byte) ((length >> 8) & 0xFF));
         output.writeByte((byte) (length & 0xFF));
       }
 
       if (maskBytes != null) {
         output.writeBytes(maskBytes);
       }
       loggablePayload.send(output, maskBytes);
-
-      if (isClosingMessage) {
-        setOutputClosed(true);
-      }
     }
 
     output.markSeparatorForLog();
   }
 
   private static void performHandshakeOrFail(ManualLoggingSocketWrapper socket,
       InetSocketAddress endpoint, String resourceId) throws IOException {
     Hybi17Handshake.Result result =
         Hybi17Handshake.performHandshake(socket, endpoint, resourceId, RANDOM);
     result.accept(HANDSHAKE_RESULT_VISITOR).get();
@@ skipping 76 matching lines @@
   }
 
   private interface StatusCode {
     int NORMAL = 1000;
     int PROTOCOL_ERROR = 1002;
     int CANNOT_ACCEPT = 1003;
   }
 
   private static final int STATUS_CODE_LENTGH = 2;
 }