browser_tests to access wss:// after proceeds anyway

browser_tests to access wss:// after proceeds anyway

BUG=53836
TEST=browser_tests --gtest_filter=SSLUITest.TestWSSInvalidCertAndGoForward

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131728

[Takashi Toyoshima, 2012-04-02 12:21:49]

Hi sky,

Recently I land CLs to handle invalid certs for wss:// by using SSLManager.
So, I'd like to add a test to check this whole behavior.

I notice that ssl_browser_tests has similar tests for https, so I feel this is
the best place to append my test.

Could you review this CL as a chrome/OWNERS, or suggest any person to look into
this CL firstly?

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/browser/ssl/s...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/browser/ssl/s...
chrome/browser/ssl/ssl_browser_tests.cc:533:
ASSERT_TRUE(wss_server.Start(wss_root_dir));
TestWebSocketServer uses new-run-webkit-websocketserver of WebKit.
It requires a directory structure, ./http/tests and ./http/tests/websocket/tests
under |wss_root_dir|. That's the reason why I store test page and WebSocket
handler in chrome/test/data/http/tests/wss.html, and
chrome/test/data/http/tests/websocket/tests/echo_wsh.py

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/data/htt...
File chrome/test/data/http/tests/websocket/tests/echo_wsh.py (right):

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/data/htt...
chrome/test/data/http/tests/websocket/tests/echo_wsh.py:1: _GOODBYE_MESSAGE =
u'Goodbye'
The WebSocket handler registers this script as a WebSocket URL handler.
This handler provides 'wss://localhost:<port>/websocket/tests/echo'.

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/data/htt...
File chrome/test/data/http/tests/wss.html (right):

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/data/htt...
chrome/test/data/http/tests/wss.html:11: var url = 'wss://localhost:' + port +
'/websocket/tests/echo';
The path /websocket/tests/ looks redundant. But actually the WebSocket server
registers handlers which exist in /websocket/tests/.

[sky, 2012-04-02 15:37:37]

the test changes LGTM, but I'm not familiar enough with ssl tests. Could you get
someone else to review? Maybe Jay.

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/base/ui_...
File chrome/test/base/ui_test_utils.cc (right):

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/base/ui_...
chrome/test/base/ui_test_utils.cc:770: : started_(false), port_(kDefaultWsPort),
secure_(false) {
nit: because this isn't all on one line, each param should be on its own line.

[Takashi Toyoshima, 2012-04-04 09:01:07]

+Jay

sky:
Thank you for review. I fixed the nit, and add Jay as a reviewer.

jcampan:
Hi Jay, could you look into this CL especially on ssl_browser_tests.cc?

Also my last try failed in linux and win. In my local machine, test works in
linux. I'll post a try job again, and investigate win32 case.

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/base/ui_...
File chrome/test/base/ui_test_utils.cc (right):

https://chromiumcodereview.appspot.com/9959062/diff/2001/chrome/test/base/ui_...
chrome/test/base/ui_test_utils.cc:770: : started_(false), port_(kDefaultWsPort),
secure_(false) {
On 2012/04/02 15:37:37, sky wrote:
> nit: because this isn't all on one line, each param should be on its own line.

Done.

[Takashi Toyoshima, 2012-04-05 09:23:15]

The reason of win_rel and linux_rel failures is that OpenSSL library for Python
is missing in try bots. I'll ask maruel on this.

So, basically, this CL itself looks fine to me.

Joy, could you review this CL?

[Takashi Toyoshima, 2012-04-06 11:21:43]

+jam

sky:
Oops... I looked into commit log.
jcampan didn't submit any change in recent two years. I'm afraid that he leaved
the project. So I'd like to add jam as another reviewer.

jam:
Hi jam, could you review this CL especially on ssl_browser_tests.cc ?
sky already reviewed this change as a OWNER, But I need another reviewer who is
familiar to ssl_browser_tests.cc. Original author jcampan is not actively
working on Chromium now. I hope you are also familiar to this.

Updates on try:
I try to fix pywebsocket to work with not pyOpenSSL but ssl because try looks
having it. I'll push this newer version of pywebsocket into WebKit. So, anyway I
could not submit this CL for a while.

[jam, 2012-04-06 17:16:02]

On 2012/04/06 11:21:43, toyoshim wrote:
> +jam
> 
> sky:
> Oops... I looked into commit log.
> jcampan didn't submit any change in recent two years. I'm afraid that he
leaved
> the project. So I'd like to add jam as another reviewer.
> 
> jam:
> Hi jam, could you review this CL especially on ssl_browser_tests.cc ?
> sky already reviewed this change as a OWNER, But I need another reviewer who
is
> familiar to ssl_browser_tests.cc. Original author jcampan is not actively
> working on Chromium now. I hope you are also familiar to this.

I'm really not familiar with these tests. Jay still works on Chrome (he works on
Chrome for Android). his user name did change, it's jcivelli

[Jay Civelli, 2012-04-07 00:56:15]

On behalf of jcampan, LGTM.
You may have to apply that patch on Windows to figure out why it's failing.

[Takashi Toyoshima, 2012-04-11 06:01:41]

Thanks Jay!

I released new version of pywebsocket and now it's available in Chromium/WebKit.
I hope this new release works in try bots.

[commit-bot: I haz the power, 2012-04-11 06:34:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9959062/14001

[commit-bot: I haz the power, 2012-04-11 06:34:46]

Presubmit check for 9959062-14001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  chrome/test/data/http/tests/websocket/tests/echo_wsh.py

Presubmit checks took 1.4s to calculate.

[commit-bot: I haz the power, 2012-04-11 06:38:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9959062/16003

[commit-bot: I haz the power, 2012-04-11 07:45:35]

Change committed as 131728