Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 9959051: Move ExternalTabContainer into a directory with an OWNERS file. (Closed)

Created:
8 years, 8 months ago by robertshield
Modified:
8 years, 8 months ago
CC:
chromium-reviews, kkania
Visibility:
Public.

Description

Move ExternalTabContainer into a directory with an OWNERS file. BUG=120901 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130508

Patch Set 1 : #

Patch Set 2 : Removing wstring. Beating a small red car with a branch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1651 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/external_tab/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/browser/external_tab/external_tab_container_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/external_tab/external_tab_container_win.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/external_tab_container_win.h View 1 chunk +0 lines, -425 lines 0 comments Download
D chrome/browser/external_tab_container_win.cc View 1 chunk +0 lines, -1217 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertshield
8 years, 8 months ago (2012-04-01 14:57:01 UTC) #1
grt (UTC plus 2)
Wdyt about using watchlist instead? Not foolproof, but doesn't interfere with SVN history/blame.
8 years, 8 months ago (2012-04-01 17:44:54 UTC) #2
robertshield
+jam@ for OWNERS
8 years, 8 months ago (2012-04-01 18:53:47 UTC) #3
robertshield
On 2012/04/01 17:44:54, grt wrote: > Wdyt about using watchlist instead? Not foolproof, but doesn't ...
8 years, 8 months ago (2012-04-01 18:59:51 UTC) #4
grt (UTC plus 2)
lgtm
8 years, 8 months ago (2012-04-02 14:03:11 UTC) #5
jam
lgtm I was just telling Ananta on Friday that you guys should do this :) ...
8 years, 8 months ago (2012-04-02 15:15:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/9959051/2001
8 years, 8 months ago (2012-04-02 18:59:44 UTC) #7
commit-bot: I haz the power
Presubmit check for 9959051-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-02 18:59:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/9959051/6001
8 years, 8 months ago (2012-04-02 23:16:33 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-03 02:27:36 UTC) #10
Try job failure for 9959051-6001 (retry) on win_rel for steps "browser_tests,
unit_tests".
It's a second try, previously, steps "browser_tests, unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698