Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 9959050: Fix fast API call for MinGW-w64 (Closed)

Created:
8 years, 8 months ago by Net147
Modified:
8 years, 8 months ago
Reviewers:
ulan, Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix fast API call for MinGW-w64 MinGW-w64 uses the rcx register for the first argument. Unlike MSVC, it does not require preparing a slot for the result handle on the stack and putting a pointer to it in the rcx register. BUGS=v8:2026 TEST=cctest/test-api Committed: https://code.google.com/p/v8/source/detail?r=11325

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Net147
8 years, 8 months ago (2012-04-01 07:55:47 UTC) #1
Net147
8 years, 8 months ago (2012-04-01 08:20:54 UTC) #2
ulan
Sorry, I am not familiar with MinGW-w64. Could you please explain why renaming the registers ...
8 years, 8 months ago (2012-04-03 16:57:19 UTC) #3
Net147
I've updated the description with more information.
8 years, 8 months ago (2012-04-08 11:41:21 UTC) #4
ulan
LGTM, I will land it for you.
8 years, 8 months ago (2012-04-16 08:58:19 UTC) #5
Net147
8 years, 8 months ago (2012-04-16 10:27:12 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698