Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2829)

Unified Diff: lib/dom/scripts/generator.py

Issue 9959048: Remove unused typed array factory constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/frog/dom_frog.dart ('k') | lib/dom/scripts/systemfrog.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/generator.py
diff --git a/lib/dom/scripts/generator.py b/lib/dom/scripts/generator.py
index fb43f50596567aad73c2f154250cc0f536cc7423..ff0701590fded44bcf855c76e13dc11ec5eba7bf 100644
--- a/lib/dom/scripts/generator.py
+++ b/lib/dom/scripts/generator.py
@@ -151,27 +151,14 @@ _alternate_methods = {
# feature in the 'native' string - the correct name is available on the DartName
# extended attribute. See Issue 1814
#
-_dom_frog_native_typed_array_set_operation = """
-if (offset == null) return this.set(array);
-return this.set(array, offset);"""
-
dom_frog_native_bodies = {
+ # Some JavaScript processors, especially tools like yuicompress and
+ # JSCompiler, choke on 'this.continue'
'IDBCursor.continueFunction':
"""
-if (key == null) return this['continue']();
-return this['continue'](key);
-""",
- 'IDBIndex.getObject': """return this.get(key);""",
- 'IDBObjectStore.getObject': """return this.get(key);""",
- 'Float32Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Float64Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Int16Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Int32Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Int8Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Uint16Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Uint32Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Uint8Array.setElements': _dom_frog_native_typed_array_set_operation,
- 'Uint8ClampedArray.setElements': _dom_frog_native_typed_array_set_operation,
+ if (key == null) return this['continue']();
+ return this['continue'](key);
+ """,
}
« no previous file with comments | « lib/dom/frog/dom_frog.dart ('k') | lib/dom/scripts/systemfrog.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698