Issue 9959037: Put the Pepper stuff in the content namespace.

Issue 9959037: Put the Pepper stuff in the content namespace. (Closed)

Created:
8 years, 8 months ago by brettw

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Put the Pepper stuff in the content namespace.

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -40 lines)			Patch
M	content/renderer/pepper/pepper_broker_impl.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_broker_impl.cc	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_broker_impl_unittest.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_device_enumeration_event_handler.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_device_enumeration_event_handler.cc	View	1	4 chunks	+11 lines, -7 lines	0 comments	Download
M	content/renderer/pepper/pepper_parent_context_provider.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_parent_context_provider.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_input_impl.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_input_impl.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_output_impl.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_output_impl.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_context_3d_impl.h	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_platform_context_3d_impl.cc	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_platform_image_2d_impl.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_image_2d_impl.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_video_capture_impl.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_video_capture_impl.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.h	View	1 2	5 chunks	+14 lines, -13 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View	1 2	13 chunks	+15 lines, -11 lines	0 comments	Download
M	content/renderer/pepper/pepper_proxy_channel_delegate_impl.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_proxy_channel_delegate_impl.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_widget_fullscreen_pepper.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_widget_fullscreen_pepper.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/9959037/diff/1/content/renderer/pepper/pepper_platform_context_3d_impl.cc File content/renderer/pepper/pepper_platform_context_3d_impl.cc (right): http://codereview.chromium.org/9959037/diff/1/content/renderer/pepper/pepper_platform_context_3d_impl.cc#newcode71 content/renderer/pepper/pepper_platform_context_3d_impl.cc:71: content::CAUSE_FOR_GPU_LAUNCH_PEPPERPLATFORMCONTEXT3DIMPL_INITIALIZE); nit: get rid of content:: now http://codereview.chromium.org/9959037/diff/1/content/renderer/pepper/pepper_plugin_delegate_impl.cc ...

8 years, 8 months ago (2012-03-30 21:50:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9959037/5003

8 years, 8 months ago (2012-04-03 06:29:05 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-03 06:29:10 UTC) #4

Can't apply patch for file content/renderer/pepper/pepper_broker_impl.cc.
While running patch -p1 --forward --force;
patching file content/renderer/pepper/pepper_broker_impl.cc
Hunk #1 succeeded at 21 with fuzz 2 (offset 2 lines).
Hunk #2 FAILED at 249.
1 out of 2 hunks FAILED -- saving rejects to file
content/renderer/pepper/pepper_broker_impl.cc.rej

Expand Messages | Collapse Messages