Allow hiding of sessions from Other Devices via context menu.

Allow hiding of sessions from Other Devices via context menu.

Also add modification times to session headers, and a separator between
multiple windows in the same session.

BUG=120200
TEST=Manual.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130125

[Patrick Dubroy, 2012-03-30 18:22:36]

Hey Evan, another "Other Devices" review for you.

The menu-on-menu thing is a bit funny, but this was approved in the UI review.
We want to keep the main Other Devices menu uncluttered so a context menu was
the best solution we could come up with.

Note, one other change here is that I put a minimum width on all of the footer
menus, including Recently Closed. Hope that's ok. IMO the menus look weird when
they are too narrow -- they don't look like menus.

[Evan Stade, 2012-03-30 21:00:30]

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/f...
File chrome/browser/resources/ntp4/footer_menu.css (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/f...
chrome/browser/resources/ntp4/footer_menu.css:124: 
extra \n

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/o...
File chrome/browser/resources/ntp4/other_sessions.js (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/o...
chrome/browser/resources/ntp4/other_sessions.js:148:
heading.classList.add('session-heading');
className =

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/o...
chrome/browser/resources/ntp4/other_sessions.js:154:
timeSpan.classList.add('details');
className =

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/for...
File chrome/browser/ui/webui/ntp/foreign_session_handler.cc (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/for...
chrome/browser/ui/webui/ntp/foreign_session_handler.cc:231: if
(!args->GetString(0, &session_string_value)) {
isn't there an ExtractString function that streamlines this process

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/for...
chrome/browser/ui/webui/ntp/foreign_session_handler.cc:237: if (associator) {
no curlies

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:366:
localized_strings.SetString("hide",
would prefer more specific variable name

[Patrick Dubroy, 2012-03-30 21:21:20]

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/f...
File chrome/browser/resources/ntp4/footer_menu.css (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/f...
chrome/browser/resources/ntp4/footer_menu.css:124: 
On 2012/03/30 21:00:30, Evan Stade wrote:
> extra \n

Done.

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/o...
File chrome/browser/resources/ntp4/other_sessions.js (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/o...
chrome/browser/resources/ntp4/other_sessions.js:148:
heading.classList.add('session-heading');
On 2012/03/30 21:00:30, Evan Stade wrote:
> className =

Done.

http://codereview.chromium.org/9959030/diff/1/chrome/browser/resources/ntp4/o...
chrome/browser/resources/ntp4/other_sessions.js:154:
timeSpan.classList.add('details');
On 2012/03/30 21:00:30, Evan Stade wrote:
> className =

Done.

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/for...
File chrome/browser/ui/webui/ntp/foreign_session_handler.cc (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/for...
chrome/browser/ui/webui/ntp/foreign_session_handler.cc:231: if
(!args->GetString(0, &session_string_value)) {
On 2012/03/30 21:00:30, Evan Stade wrote:
> isn't there an ExtractString function that streamlines this process

Done.

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/for...
chrome/browser/ui/webui/ntp/foreign_session_handler.cc:237: if (associator) {
On 2012/03/30 21:00:30, Evan Stade wrote:
> no curlies

Done.

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/9959030/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:366:
localized_strings.SetString("hide",
On 2012/03/30 21:00:30, Evan Stade wrote:
> would prefer more specific variable name

Done.

[Evan Stade, 2012-03-30 21:40:58]

lgtm

http://codereview.chromium.org/9959030/diff/9/chrome/browser/resources/ntp4/o...
File chrome/browser/resources/ntp4/other_sessions.js (right):

http://codereview.chromium.org/9959030/diff/9/chrome/browser/resources/ntp4/o...
chrome/browser/resources/ntp4/other_sessions.js:230: function
DeviceContextMenu() {
probably should be called DeviceContextMenuController or something because its
current name suggests it inherits from Menu