Fix some uses of global variables in transient pages.

chrome/renderer/extensions/extension_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/extension_dispatcher.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_piece.h"
 #include "chrome/common/child_process_logging.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_view_type.h"
 #include "chrome/common/extensions/api/extension_api.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/extensions/extension_permission_set.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/chrome_render_process_observer.h"
 #include "chrome/renderer/extensions/app_bindings.h"
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "chrome/renderer/extensions/chrome_v8_extension.h"
 #include "chrome/renderer/extensions/context_menus_custom_bindings.h"
 #include "chrome/renderer/extensions/event_bindings.h"
 #include "chrome/renderer/extensions/experimental.socket_custom_bindings.h"
 #include "chrome/renderer/extensions/extension_custom_bindings.h"
 #include "chrome/renderer/extensions/extension_groups.h"
+#include "chrome/renderer/extensions/extension_helper.h"
 #include "chrome/renderer/extensions/extension_request_sender.h"
 #include "chrome/renderer/extensions/file_browser_handler_custom_bindings.h"
 #include "chrome/renderer/extensions/file_browser_private_custom_bindings.h"
 #include "chrome/renderer/extensions/i18n_custom_bindings.h"
 #include "chrome/renderer/extensions/miscellaneous_bindings.h"
 #include "chrome/renderer/extensions/page_actions_custom_bindings.h"
 #include "chrome/renderer/extensions/page_capture_custom_bindings.h"
 #include "chrome/renderer/extensions/schema_generated_bindings.h"
 #include "chrome/renderer/extensions/tabs_custom_bindings.h"
 #include "chrome/renderer/extensions/tts_custom_bindings.h"
@@ skipping 76 matching lines @@
 
     std::vector<std::string> components;
     for (int i = 0; i < args.Length(); ++i)
       components.push_back(*v8::String::Utf8Value(args[i]->ToString()));
 
     LOG(ERROR) << JoinString(components, ',');
     return v8::Undefined();
   }
 };
 
+class LazyBackgroundPageNativeHandler : public ChromeV8Extension {
+ public:
+  explicit LazyBackgroundPageNativeHandler(ExtensionDispatcher* dispatcher)
+      : ChromeV8Extension(dispatcher) {
+    RouteFunction("IncrementKeepaliveCount",
+        base::Bind(&LazyBackgroundPageNativeHandler::IncrementKeepaliveCount,
+                   base::Unretained(this)));
+    RouteFunction("DecrementKeepaliveCount",
+        base::Bind(&LazyBackgroundPageNativeHandler::DecrementKeepaliveCount,
+                   base::Unretained(this)));
+  }
+
+  v8::Handle<v8::Value> IncrementKeepaliveCount(const v8::Arguments& args) {
+    ChromeV8Context* context =
+        extension_dispatcher()->v8_context_set().GetCurrent();
+    if (IsLazyBackgroundPage(context->extension_id())) {
+      content::RenderThread::Get()->Send(
+          new ExtensionHostMsg_IncrementLazyKeepaliveCount(
+              context->extension_id()));
+    }
+    return v8::Undefined();
+  }
+
+  v8::Handle<v8::Value> DecrementKeepaliveCount(const v8::Arguments& args) {
+    ChromeV8Context* context =
+        extension_dispatcher()->v8_context_set().GetCurrent();
+    if (IsLazyBackgroundPage(context->extension_id())) {
+      content::RenderThread::Get()->Send(
+          new ExtensionHostMsg_DecrementLazyKeepaliveCount(
+              context->extension_id()));
+    }
+    return v8::Undefined();
+  }
+
+ private:
+  bool IsLazyBackgroundPage(const std::string& extension_id) {

[Yoyo Zhou, 2012/04/04 18:52:24]

This name seems to be... off.

[Matt Perry, 2012/04/04 19:21:44]

Changed to IsCurrentContextLazyBackgroundPage

+    content::RenderView* render_view = GetCurrentRenderView();
+    if (!render_view)
+      return false;
+
+    ExtensionHelper* helper = ExtensionHelper::Get(render_view);
+    const ::Extension* extension =
+        extension_dispatcher()->extensions()->GetByID(extension_id);
+    return (extension && extension->has_lazy_background_page() &&
+            helper->view_type() == chrome::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE);
+  }
+};
+
 void InstallAppBindings(ModuleSystem* module_system,
                         v8::Handle<v8::Object> chrome,
                         v8::Handle<v8::Object> chrome_hidden) {
   module_system->SetLazyField(chrome, "app", "app", "chromeApp");
   module_system->SetLazyField(chrome, "appNotifications", "app",
                               "chromeAppNotifications");
   module_system->SetLazyField(chrome_hidden, "app", "app",
                               "chromeHiddenApp");
 }
 
@@ skipping 400 matching lines @@
   scoped_ptr<ModuleSystem> module_system(new ModuleSystem(&source_map_));
   // Enable natives in startup.
   ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system.get());
 
   RegisterNativeHandlers(module_system.get(), context);
 
   module_system->RegisterNativeHandler("chrome_hidden",
       scoped_ptr<NativeHandler>(new ChromeHiddenNativeHandler()));
   module_system->RegisterNativeHandler("print",
       scoped_ptr<NativeHandler>(new PrintNativeHandler()));
+  module_system->RegisterNativeHandler("lazy_background_page",
+      scoped_ptr<NativeHandler>(new LazyBackgroundPageNativeHandler(this)));
 
   int manifest_version = 1;
   if (extension)
     manifest_version = extension->manifest_version();
 
   // Create the 'chrome' variable if it doesn't already exist.
   {
     v8::HandleScope handle_scope;
     v8::Handle<v8::String> chrome_string(v8::String::New("chrome"));
     v8::Handle<v8::Object> global(v8::Context::GetCurrent()->Global());
@@ skipping 285 matching lines @@
     static const char kMessage[] =
         "%s can only be used in an extension process.";
     std::string error_msg = base::StringPrintf(kMessage, function_name.c_str());
     v8::ThrowException(
         v8::Exception::Error(v8::String::New(error_msg.c_str())));
     return false;
   }
 
   return true;
 }