Issue 9958146: Revert 130500 - Merge 130082 - Add an injectKeyEvent API to the Chromoting client plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9958146: Revert 130500 - Merge 130082 - Add an injectKeyEvent API to the Chromoting client plugin. (Closed)

Created:
8 years, 8 months ago by Wez

Modified:
8 years, 8 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

More Reviews

Description

Revert 130500 - Merge 130082 - Add an injectKeyEvent API to the Chromoting client plugin. This broke the Mac build, at least. The API allows a key (identified by USB-style identifier) event to be injected into the host by the web-application, to allow it to provide UI to inject key sequences that would not otherwise be possible on the client system (e.g. injecting Ctrl-Alt-Del from Windows, WinKey from CrOS, etc). BUG=105736, 120313 TEST=Will be manually testable by verifying that the Send Ctrl-Alt-Del button works, once implemented in a follow-up CL. Review URL: http://codereview.chromium.org/9968030 TBR=wez@chromium.org Review URL: https://chromiumcodereview.appspot.com/9958141 TBR=wez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130519

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -45 lines)			Patch
M	remoting/client/plugin/chromoting_instance.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View	2 chunks	+2 lines, -21 lines	0 comments	Download
M	remoting/webapp/client_plugin.js	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	remoting/webapp/client_plugin_async.js	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages