Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 9958134: Adds some debugging code to verify the dictionaries are non-null at (Closed)

Created:
8 years, 8 months ago by sky
Modified:
8 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Adds some debugging code to verify the dictionaries are non-null at construction time. Based on some crashes it seems as though these can be NULL later on. BUG=121584 TEST=none R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/history/top_sites.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
8 years, 8 months ago (2012-04-03 21:53:46 UTC) #1
brettw
lgtm
8 years, 8 months ago (2012-04-03 22:03:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9958134/1
8 years, 8 months ago (2012-04-03 22:07:43 UTC) #3
commit-bot: I haz the power
Try job failure for 9958134-1 (retry) on win_rel for steps "browser_tests, unit_tests". It's a second ...
8 years, 8 months ago (2012-04-04 02:28:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9958134/1
8 years, 8 months ago (2012-04-04 03:39:35 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-04 06:33:18 UTC) #6
Try job failure for 9958134-1 (retry) on win_rel for steps "browser_tests,
unit_tests".
It's a second try, previously, steps "browser_tests, unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698