chrome/browser/browsing_data_quota_helper_impl.cc - Issue 9958107: Limiting the "Cookies and site data" form to "web safe" schemes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data_quota_helper_impl.cc

Issue 9958107: Limiting the "Cookies and site data" form to "web safe" schemes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: License. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data_quota_helper_impl.cc

diff --git a/chrome/browser/browsing_data_quota_helper_impl.cc b/chrome/browser/browsing_data_quota_helper_impl.cc

index 04a9a734300e2f03e50e5e06c8d15f699c807ae7..ed8bb71252a922f76c2f3064a9ad3bed43fb117d 100644

--- a/chrome/browser/browsing_data_quota_helper_impl.cc

+++ b/chrome/browser/browsing_data_quota_helper_impl.cc

@@ -11,6 +11,7 @@

#include "base/logging.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/url_constants.h"

+#include "chrome/browser/browsing_data_helper.h"

#include "webkit/quota/quota_manager.h"

using content::BrowserThread;

@@ -88,7 +89,7 @@ void BrowsingDataQuotaHelperImpl::GotOrigins(

for (std::set<GURL>::const_iterator itr = origins.begin();

itr != origins.end();

++itr)

- if (!itr->SchemeIs(chrome::kExtensionScheme))

+ if (BrowsingDataHelper::HasValidScheme(*itr))

pending_hosts_.insert(std::make_pair(itr->host(), type));

DCHECK(type == quota::kStorageTypeTemporary ||