Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/browsing_data_file_system_helper_unittest.cc

Issue 9958107: Limiting the "Cookies and site data" form to "web safe" schemes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: The others. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_file_system_helper_unittest.cc
diff --git a/chrome/browser/browsing_data_file_system_helper_unittest.cc b/chrome/browser/browsing_data_file_system_helper_unittest.cc
index 8ed961bb360f1a0429f90380ec28d2d4c4e387cc..5aae87056401b35e929c80b0f4eeb6cca908985f 100644
--- a/chrome/browser/browsing_data_file_system_helper_unittest.cc
+++ b/chrome/browser/browsing_data_file_system_helper_unittest.cc
@@ -33,9 +33,15 @@ const char kTestOrigin1[] = "http://host1:1/";
const char kTestOrigin2[] = "http://host2:2/";
const char kTestOrigin3[] = "http://host3:3/";
+// Extensions and Devtools should be ignored.
+const char kTestOriginExt[] = "chrome-extension://abcdefghijklmnopqrstuvwxyz/";
+const char kTestOriginDevTools[] = "chrome-devtools://abcdefghijklmnopqrstuvw/";
+
const GURL kOrigin1(kTestOrigin1);
const GURL kOrigin2(kTestOrigin2);
const GURL kOrigin3(kTestOrigin3);
+const GURL kOriginExt(kTestOriginExt);
+const GURL kOriginDevTools(kTestOriginDevTools);
// TODO(mkwst): Update this size once the discussion in http://crbug.com/86114
// is concluded.
@@ -298,4 +304,14 @@ TEST_F(BrowsingDataFileSystemHelperTest, CannedAddFileSystem) {
EXPECT_EQ(100, info->usage_temporary);
}
+// Verifies that the CannedBrowsingDataFileSystemHelper correctly ignores
+// extension and devtools schemes.
+TEST_F(BrowsingDataFileSystemHelperTest, IgnoreExtensionsAndDevTools) {
+ ASSERT_TRUE(canned_helper_->empty());
+ canned_helper_->AddFileSystem(kOriginExt, kTemporary, 0);
+ ASSERT_TRUE(canned_helper_->empty());
+ canned_helper_->AddFileSystem(kOriginDevTools, kTemporary, 0);
+ ASSERT_TRUE(canned_helper_->empty());
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698