webkit/plugins/npapi/webplugin_delegate_impl.h - Issue 9958104: Log when a browser plugin hangs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/webplugin_delegate_impl.h

Issue 9958104: Log when a browser plugin hangs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update based on jam@'s review comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/npapi/webplugin_delegate_impl.h

diff --git a/webkit/plugins/npapi/webplugin_delegate_impl.h b/webkit/plugins/npapi/webplugin_delegate_impl.h

index 102cd3cf93615333765980d717252fa0538138b0..419295fdeb96ee7249d24a3bdaf417dce6ae909c 100644

--- a/webkit/plugins/npapi/webplugin_delegate_impl.h

+++ b/webkit/plugins/npapi/webplugin_delegate_impl.h

@@ -95,6 +95,8 @@ class WEBKIT_PLUGINS_EXPORT WebPluginDelegateImpl : public WebPluginDelegate {

static bool IsPluginDelegateWindow(gfx::NativeWindow window);

static bool GetPluginNameFromWindow(gfx::NativeWindow window,

string16* plugin_name);

+ static bool GetPluginVersionFromWindow(gfx::NativeWindow window,

+ string16* plugin_version);

// Returns true if the window handle passed in is that of the dummy

// activation window for windowless plugins.